Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Unified Diff: src/debug/mips/debug-mips.cc

Issue 1494143002: Revert of [debugger] do not predict step in target for liveedit. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@liveeditstep
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/debug/liveedit.cc ('k') | src/debug/mips64/debug-mips64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/debug/mips/debug-mips.cc
diff --git a/src/debug/mips/debug-mips.cc b/src/debug/mips/debug-mips.cc
index bb44e682d12adaac79e10ae301ca166380dbc58d..c1d24c447effb8a81a52cacc877af255de8a089c 100644
--- a/src/debug/mips/debug-mips.cc
+++ b/src/debug/mips/debug-mips.cc
@@ -109,16 +109,22 @@
}
+void DebugCodegen::GeneratePlainReturnLiveEdit(MacroAssembler* masm) {
+ __ Ret();
+}
+
+
void DebugCodegen::GenerateFrameDropperLiveEdit(MacroAssembler* masm) {
+ ExternalReference restarter_frame_function_slot =
+ ExternalReference::debug_restarter_frame_function_pointer_address(
+ masm->isolate());
+ __ li(at, Operand(restarter_frame_function_slot));
+ __ sw(zero_reg, MemOperand(at, 0));
+
// We do not know our frame height, but set sp based on fp.
__ Subu(sp, fp, Operand(kPointerSize));
- __ Pop(a1); // Function.
-
- ParameterCount dummy(0);
- __ FloodFunctionIfStepping(a1, no_reg, dummy, dummy);
-
- __ Pop(ra, fp); // Return address, Frame.
+ __ Pop(ra, fp, a1); // Return address, Frame, Function.
// Load context from the function.
__ lw(cp, FieldMemOperand(a1, JSFunction::kContextOffset));
« no previous file with comments | « src/debug/liveedit.cc ('k') | src/debug/mips64/debug-mips64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698