Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: src/a64/stub-cache-a64.cc

Issue 149413010: A64: Synchronize with r16024. (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/a64
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/a64/regexp-macro-assembler-a64.cc ('k') | src/accessors.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/a64/stub-cache-a64.cc
diff --git a/src/a64/stub-cache-a64.cc b/src/a64/stub-cache-a64.cc
index bf7677f3021dec0e3bd64f6b33c21752ca7fc494..203fcc3715e0621f212cc74e3d0be0ca1dc947b3 100644
--- a/src/a64/stub-cache-a64.cc
+++ b/src/a64/stub-cache-a64.cc
@@ -3450,11 +3450,7 @@ void KeyedStoreStubCompiler::GenerateStoreExternalArray(
// This stub is meant to be tail-jumped to, the receiver must already
// have been verified by the caller to not be a smi.
if (__ emit_debug_code()) {
- Label ok;
- __ JumpIfNotSmi(receiver, &ok);
- __ Abort("KeyedStoreStubCompiler::GenerateStoreExternalArray: "
- "receiver is a SMI\n");
- __ Bind(&ok);
+ __ AssertNotSmi(receiver);
}
// Check that the key is a smi or a heap number convertible to a smi.
@@ -3552,10 +3548,7 @@ static void GenerateStoreFastSmiOrDoubleElement(
// This stub is meant to be tail-jumped to, the receiver must already
// have been verified by the caller to not be a smi.
if (__ emit_debug_code()) {
- Label ok;
- __ JumpIfNotSmi(receiver, &ok);
- __ Abort("GenerateStoreFastSmiOrDoubleElement: receiver is a SMI\n");
- __ Bind(&ok);
+ __ AssertNotSmi(receiver);
}
// Check that the key is a smi or a heap number convertible to a smi.
@@ -3647,8 +3640,7 @@ static void GenerateStoreFastSmiOrDoubleElement(
// by one element.
__ Ccmp(x1, x4, NoFlag, eq);
- __ Check(eq, "GenerateStoreFastSmiOrDoubleElement [grow]: "
- "Preconditions were not met.");
+ __ Check(eq, kPreconditionsWereNotMet);
}
__ JumpIfNotRoot(elements, Heap::kEmptyFixedArrayRootIndex,
« no previous file with comments | « src/a64/regexp-macro-assembler-a64.cc ('k') | src/accessors.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698