Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: src/a64/builtins-a64.cc

Issue 149413010: A64: Synchronize with r16024. (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/a64
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « include/v8.h ('k') | src/a64/code-stubs-a64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/a64/builtins-a64.cc
diff --git a/src/a64/builtins-a64.cc b/src/a64/builtins-a64.cc
index 00de9105d8985dc987cd23860a440d61bf87f2f0..e39fe13c7ab5fbc4df05cfb6ab31fe380b27af2f 100644
--- a/src/a64/builtins-a64.cc
+++ b/src/a64/builtins-a64.cc
@@ -114,9 +114,9 @@ void Builtins::Generate_InternalArrayCode(MacroAssembler* masm) {
// Initial map for the builtin InternalArray functions should be maps.
__ Ldr(x10, FieldMemOperand(x1, JSFunction::kPrototypeOrInitialMapOffset));
__ Tst(x10, kSmiTagMask);
- __ Assert(ne, "Unexpected initial map for InternalArray function");
+ __ Assert(ne, kUnexpectedInitialMapForInternalArrayFunction);
__ CompareObjectType(x10, x11, x12, MAP_TYPE);
- __ Assert(eq, "Unexpected initial map for InternalArray function");
+ __ Assert(eq, kUnexpectedInitialMapForInternalArrayFunction);
}
// Run the native code for the InternalArray function called as a normal
@@ -142,9 +142,9 @@ void Builtins::Generate_ArrayCode(MacroAssembler* masm) {
// Initial map for the builtin Array functions should be maps.
__ Ldr(x10, FieldMemOperand(x1, JSFunction::kPrototypeOrInitialMapOffset));
__ Tst(x10, kSmiTagMask);
- __ Assert(ne, "Unexpected initial map for Array function");
+ __ Assert(ne, kUnexpectedInitialMapForArrayFunction);
__ CompareObjectType(x10, x11, x12, MAP_TYPE);
- __ Assert(eq, "Unexpected initial map for Array function");
+ __ Assert(eq, kUnexpectedInitialMapForArrayFunction);
}
// Run the native code for the Array function called as a normal function.
@@ -174,7 +174,7 @@ void Builtins::Generate_StringConstructCode(MacroAssembler* masm) {
if (FLAG_debug_code) {
__ LoadGlobalFunction(Context::STRING_FUNCTION_INDEX, x10);
__ Cmp(function, x10);
- __ Assert(eq, "Unexpected String function");
+ __ Assert(eq, kUnexpectedStringFunction);
}
// Load the first arguments in x0 and get rid of the rest.
@@ -216,10 +216,10 @@ void Builtins::Generate_StringConstructCode(MacroAssembler* masm) {
if (FLAG_debug_code) {
__ Ldrb(x4, FieldMemOperand(map, Map::kInstanceSizeOffset));
__ Cmp(x4, JSValue::kSize >> kPointerSizeLog2);
- __ Assert(eq, "Unexpected string wrapper instance size");
+ __ Assert(eq, kUnexpectedStringWrapperInstanceSize);
__ Ldrb(x4, FieldMemOperand(map, Map::kUnusedPropertyFieldsOffset));
__ Cmp(x4, 0);
- __ Assert(eq, "Unexpected unused properties of string wrapper");
+ __ Assert(eq, kUnexpectedUnusedPropertiesOfStringWrapper);
}
__ Str(map, FieldMemOperand(new_obj, HeapObject::kMapOffset));
@@ -461,7 +461,7 @@ static void Generate_JSConstructStubHelper(MacroAssembler* masm,
if (FLAG_debug_code) {
__ Cmp(first_non_prealloc, obj_end);
- __ Assert(le, "Unexpected number of pre-allocated property fields");
+ __ Assert(le, kUnexpectedNumberOfPreAllocatedPropertyFields);
}
__ InitializeFieldsWithFiller(first_prop, first_non_prealloc, undef);
// To allow for truncation.
@@ -488,7 +488,7 @@ static void Generate_JSConstructStubHelper(MacroAssembler* masm,
// Done if no extra properties are to be allocated.
__ B(eq, &allocated);
- __ Assert(pl, "Property allocation count failed");
+ __ Assert(pl, kPropertyAllocationCountFailed);
// Scale the number of elements by pointer size and add the header for
// FixedArrays to the start of the next object calculation from above.
@@ -900,7 +900,7 @@ static void Generate_NotifyDeoptimizedHelper(MacroAssembler* masm,
__ Ret();
__ Bind(&unknown_state);
- __ Abort("Invalid fullcodegen state.");
+ __ Abort(kInvalidFullCodegenState);
}
@@ -1199,7 +1199,7 @@ void Builtins::Generate_FunctionApply(MacroAssembler* masm) {
__ InvokeBuiltin(Builtins::APPLY_OVERFLOW, CALL_FUNCTION);
// We should never return from the APPLY_OVERFLOW builtin.
if (__ emit_debug_code()) {
- __ Abort("Unreachable code.");
+ __ Unreachable();
}
__ Bind(&enough_stack_space);
« no previous file with comments | « include/v8.h ('k') | src/a64/code-stubs-a64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698