QUIC - Start the process for reading crypto config data from disk cache

net/quic/crypto/quic_crypto_client_config.h

Index: net/quic/crypto/quic_crypto_client_config.h
diff --git a/net/quic/crypto/quic_crypto_client_config.h b/net/quic/crypto/quic_crypto_client_config.h
index a7c58804c128e2f70a465446e469465770b91d69..8fac2b1cbaa00afaab98e3370192679d152403d1 100644
--- a/net/quic/crypto/quic_crypto_client_config.h
+++ b/net/quic/crypto/quic_crypto_client_config.h
@@ -31,6 +31,7 @@ class NET_EXPORT_PRIVATE QuicCryptoClientConfig : public QuicCryptoConfig {
   class NET_EXPORT_PRIVATE CachedState {
    public:
     CachedState();
+    explicit CachedState(scoped_ptr<QuicServerInfo> quic_server_info);
     ~CachedState();
 
     // IsComplete returns true if this object contains enough information to
@@ -89,11 +90,6 @@ class NET_EXPORT_PRIVATE QuicCryptoClientConfig : public QuicCryptoConfig {
     // unchanged.
     void InitializeFrom(const CachedState& other);
 
-    // TODO(rtenneti): Need to flesh out the details of this method. A temporary
-    // place holder to load CachedState from disk cache.
-    void LoadFromDiskCache(QuicServerInfoFactory* quic_server_info_factory,
-                           const std::string& server_hostname);
-
    private:
     std::string server_config_id_;      // An opaque id from the server.
     std::string server_config_;         // A serialized handshake message.
@@ -114,19 +110,25 @@ class NET_EXPORT_PRIVATE QuicCryptoClientConfig : public QuicCryptoConfig {
     // scfg contains the cached, parsed value of |server_config|.
     mutable scoped_ptr<CryptoHandshakeMessage> scfg_;
 
+    // |quic_server_info_| is used to fetch crypto config information from disk.
     scoped_ptr<QuicServerInfo> quic_server_info_;
 
     DISALLOW_COPY_AND_ASSIGN(CachedState);
   };
 
   QuicCryptoClientConfig();
-  explicit QuicCryptoClientConfig(
-      QuicServerInfoFactory* quic_server_info_factory);
   ~QuicCryptoClientConfig();
 
   // Sets the members to reasonable, default values.
   void SetDefaults();
 
+  // Create returns a CachedState for the given hostname. It creates CachedState

[wtc, 2014/02/05 00:03:25]

Nit: add "a" between "creates" and "CachedState".

[ramant (doing other things), 2014/02/05 00:40:39]

Done.

+  // and caches it. If |quic_server_info_factory| is not NULL, then it is used
+  // to create |quic_server_info_| which is used to fetch crypto config

[wtc, 2014/02/05 00:03:25]

Nit: change "|quic_server_info_|" to "a QuicServerInfo", because this class
doesn't have a quic_server_info_ member.

[ramant (doing other things), 2014/02/05 00:40:39]

Done.

+  // information from disk for the given hostname.
+  CachedState* Create(const std::string& server_hostname,
+                      QuicServerInfoFactory* quic_server_info_factory);
+
   // LookupOrCreate returns a CachedState for the given hostname. If no such
   // CachedState currently exists, it will be created and cached.
   CachedState* LookupOrCreate(const std::string& server_hostname);

[wtc, 2014/02/05 00:03:25]

Nit: it is a little strange that LookupOrCreate doesn't take a
quic_server_info_factory argument, but the closely related Create method does.

[ramant (doing other things), 2014/02/05 00:40:39]

ACK. LookupOrCreate is used by the server code (net/tools/quic). Added a TODO.

@@ -219,7 +221,6 @@ class NET_EXPORT_PRIVATE QuicCryptoClientConfig : public QuicCryptoConfig {
   // about that server.
   std::map<std::string, CachedState*> cached_states_;
 
-  QuicServerInfoFactory* quic_server_info_factory_;
   scoped_ptr<ProofVerifier> proof_verifier_;
   scoped_ptr<ChannelIDSigner> channel_id_signer_;