Issue 149413005: Don't parallelize tests that register extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149413005: Don't parallelize tests that register extensions. (Closed)

Created:
6 years, 10 months ago by Michael Achenbach

Modified:
6 years, 10 months ago

Reviewers:
dcarney

CC:
v8-dev, Jakob Kummerow, Toon Verwaest

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Don't parallelize tests that register extensions. These tests register extensions on the isolate and the configuration of the extensions runs out of scope. If run in parallel, other tests access the isolate's state and read the registered extensions. BUG= R=dcarney@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18921

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -14 lines)			Patch
	M	test/cctest/test-api.cc	View		14 chunks	+14 lines, -14 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Achenbach

6 years, 10 months ago (2014-01-29 15:30:05 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r18921 (presubmit successful).

Expand Messages | Collapse Messages