HTMLInputElement.valueAsNumber compliance (NaN handling.)

Source/core/html/forms/BaseDateAndTimeInputType.cpp

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 46 matching lines @@
 {
     element().setValue(serializeWithMilliseconds(value));
 }
 
 double BaseDateAndTimeInputType::valueAsDouble() const
 {
     const Decimal value = parseToNumber(element().value(), Decimal::nan());
     return value.isFinite() ? value.toDouble() : DateComponents::invalidMilliseconds();
 }
 
-void BaseDateAndTimeInputType::setValueAsDecimal(const Decimal& newValue, TextFieldEventBehavior eventBehavior, ExceptionState&) const
+void BaseDateAndTimeInputType::setValueAsDouble(double newValue, TextFieldEventBehavior eventBehavior, ExceptionState& exceptionState) const

[Mike West, 2014/01/29 19:31:37]

Why did this change from `Decimal` to `double`?

[sof, 2014/01/29 19:53:41]

Good question, not sure I have a succinct answer, but let me try to explain:

- The setValueAsDouble() and setValueAsDate() methods on the base class
InputType now throw InvalidStateErrors to indicate non-support for setting
either property.

- Anything date-related will as a consequence have to override
setValueAsNumber() (and setValueAsDate()), as they support both properties
(well... datetime-local is the odd one out.) Which explains the
setValueAsDouble() override added here.

- InputType::setValueAsDecimal() used to throw; there's no good reason why it
should any longer, hence I made it perform the usual serialization of the
incoming Decimal value. Consequently, BaseDateAndTimeInputType no longer needs
to override setValueAsDecimal(), but can rely on the base implementation
provided by InputType.

 {
-    element().setValue(serialize(newValue), eventBehavior);
+    setValueAsDecimal(Decimal::fromDouble(newValue), eventBehavior, exceptionState);
 }
 
 bool BaseDateAndTimeInputType::typeMismatchFor(const String& value) const
 {
     return !value.isEmpty() && !parseToDateComponents(value, 0);
 }
 
 bool BaseDateAndTimeInputType::typeMismatch() const
 {
     return typeMismatchFor(element().value());
@@ skipping 104 matching lines @@
 {
     return element().isRequired() && value.isEmpty();
 }
 
 bool BaseDateAndTimeInputType::shouldShowFocusRingOnMouseFocus() const
 {
     return true;
 }
 
 } // namespace WebCore