Issue 149413002: drive: Make CopyOperation aware of locally created files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149413002: drive: Make CopyOperation aware of locally created files (Closed)

Created:
6 years, 10 months ago by hashimoto

Modified:
6 years, 10 months ago

Reviewers:
kinaba

CC:
chromium-reviews, nkostylev+watch_chromium.org, tzik, tfarina, nhiroki, oshima+watch_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

drive: Make CopyOperation aware of locally created files Perform copy locally if the file is dirty or it doesn't have a resource ID. Fix Copy()'s behavior to overwrite existing file. Remove dependency from MoveOperationTest to CopyOperation. BUG=260539, 331985 TEST=unit_tests R=kinaba@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247834

Patch Set 1 : #

Patch Set 2 : Fix mistakenly called CopyResourceOnServer #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+241 lines, -111 lines)			Patch
M	chrome/browser/chromeos/drive/file_system/copy_operation.h	View	1	1 chunk	+8 lines, -6 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_system/copy_operation.cc	View	1	3 chunks	+117 lines, -44 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_system/copy_operation_unittest.cc	View		2 chunks	+116 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_system/move_operation_unittest.cc	View		3 chunks	+0 lines, -61 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

hashimoto

6 years, 10 months ago (2014-01-30 04:47:40 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r247834 (presubmit successful).

Expand Messages | Collapse Messages