Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Unified Diff: test/cctest/compiler/test-run-native-calls.cc

Issue 1494123002: [turbofan, arm64] Fix native stack parameters on arm64. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/compiler/arm64/code-generator-arm64.cc ('K') | « src/compiler/linkage.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/compiler/test-run-native-calls.cc
diff --git a/test/cctest/compiler/test-run-native-calls.cc b/test/cctest/compiler/test-run-native-calls.cc
index 9311c02748e08e8fa2f126dba957aca650861473..21d76c0afdc6336e2d3c1ca9de4497e745b4e55b 100644
--- a/test/cctest/compiler/test-run-native-calls.cc
+++ b/test/cctest/compiler/test-run-native-calls.cc
@@ -21,12 +21,7 @@ namespace v8 {
namespace internal {
namespace compiler {
-#if V8_TARGET_ARCH_ARM64
titzer 2015/12/03 11:31:59 You can go ahead and remove the uses of this predi
ahaas 2015/12/03 15:25:06 Done.
-// TODO(titzer): fix native stack parameters on arm64
-#define DISABLE_NATIVE_STACK_PARAMS true
-#else
#define DISABLE_NATIVE_STACK_PARAMS false
-#endif
namespace {
typedef float float32;
@@ -221,7 +216,7 @@ class RegisterConfig {
compiler::Operator::kNoProperties, // properties
kCalleeSaveRegisters, // callee-saved registers
kCalleeSaveFPRegisters, // callee-saved fp regs
- CallDescriptor::kNoFlags, // flags
+ CallDescriptor::kUseNativeStack, // flags
"c-call");
}
@@ -1045,7 +1040,7 @@ void MixedParamTest(int start) {
#else
static MachineType types[] = {
kMachInt32, kMachInt64, kMachFloat32, kMachFloat64, kMachInt32,
- kMachFloat64, kMachFloat32, kMachInt64, kMachFloat64, kMachInt32,
+ kMachFloat64, kMachFloat32, kMachInt64, kMachInt64, kMachFloat32,
kMachFloat32, kMachInt32, kMachFloat64, kMachFloat64, kMachInt64,
kMachInt32, kMachFloat64, kMachInt32, kMachFloat32};
#endif
« src/compiler/arm64/code-generator-arm64.cc ('K') | « src/compiler/linkage.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698