Set up depot_tools as a recipe package, and add depot_tools recipe module.

Set up depot_tools as a recipe package, and add depot_tools recipe module.

This is a good prototypical example of how to do it :-).

TBR for OWNERS change for recipes.cfg.  

BUG=564920
R=iannucci@chromium.org,martiniss@chromium.org
TBR=phajdan.jr@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=297851

[luqui, 2015-12-04 02:17:58]

ptal

[martiniss, 2015-12-04 02:49:23]

lgtm --> (love great times man)

https://codereview.chromium.org/1494103004/diff/1/tests/recipes_test.py
File tests/recipes_test.py (right):

https://codereview.chromium.org/1494103004/diff/1/tests/recipes_test.py#newcode1
tests/recipes_test.py:1: #!/usr/bin/env python
Umm. This is a good idea. Do we want to package this somehow for users? I think
they would want to add this test to their repo somehow. Copy pasta?

[luqui, 2015-12-04 17:58:01]

https://codereview.chromium.org/1494103004/diff/1/tests/recipes_test.py
File tests/recipes_test.py (right):

https://codereview.chromium.org/1494103004/diff/1/tests/recipes_test.py#newcode1
tests/recipes_test.py:1: #!/usr/bin/env python
On 2015/12/04 02:49:23, martiniss wrote:
> Umm. This is a good idea. Do we want to package this somehow for users? I
think
> they would want to add this test to their repo somehow. Copy pasta?

This is as packaged as I could come up with while still being flexible with the
different ways repos' tests are structured.  Any ideas?

(Note that we have to include the coverage threshold somewhere)

[luqui, 2015-12-04 17:58:20]

The CQ bit was checked by luqui@chromium.org

[commit-bot: I haz the power, 2015-12-04 17:58:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1494103004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1494103004/1

[commit-bot: I haz the power, 2015-12-04 18:02:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-04 18:02:55]

Try jobs failed on following builders:
  depot_tools_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/depot_tools_pre...)

[Dirk Pranke, 2015-12-04 18:05:57]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2015-12-04 18:05:57]

I'm not sure I understand the bigger picture here.

Are we trying to get to the point where depot_tools can be pulled in via recipes
and DEPS and exposes an API, rather than just assumed to exist outside of the
framework?

(Which sounds like a good idea, just trying to follow things)

[luqui, 2015-12-04 18:13:20]

On 2015/12/04 18:05:57, Dirk Pranke wrote:
> I'm not sure I understand the bigger picture here.
> 
> Are we trying to get to the point where depot_tools can be pulled in via
recipes
> and DEPS and exposes an API, rather than just assumed to exist outside of the
> framework?
> 
> (Which sounds like a good idea, just trying to follow things)

Yep, that's the plan.  Immediately, this is part of nodir@'s project to run a
recipe on a bare slave (i.e. barely provisioned).  But long term we can stop
assuming depot_tools to be provisioned on any bot, and have it pinned.

[iannucci, 2015-12-04 20:17:17]

lgtm

https://chromiumcodereview.appspot.com/1494103004/diff/20001/infra/config/rec...
File infra/config/recipes.cfg (right):

https://chromiumcodereview.appspot.com/1494103004/diff/20001/infra/config/rec...
infra/config/recipes.cfg:1: api_version: 1
it occurs to me that this is maybe a poorly chosen key name. maybe
'proto_version' would be better?

https://chromiumcodereview.appspot.com/1494103004/diff/20001/recipes.py
File recipes.py (right):

https://chromiumcodereview.appspot.com/1494103004/diff/20001/recipes.py#newco...
recipes.py:136: sys.exit(main())
This is getting a bit long for copy-paste. Is there anything we can do to make
it shorter? I guess most of it is a parser for recipes.cfg...

[luqui, 2015-12-04 22:38:30]

The CQ bit was checked by luqui@chromium.org

[luqui, 2015-12-04 22:38:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
martiniss@chromium.org
Link to the patchset: https://codereview.chromium.org/1494103004/#ps20001
(title: " ")

[commit-bot: I haz the power, 2015-12-04 22:38:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1494103004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1494103004/20001

[commit-bot: I haz the power, 2015-12-04 22:54:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-04 22:54:24]

Try jobs failed on following builders:
  depot_tools_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/depot_tools_pre...)

[luqui, 2015-12-04 23:07:09]

Description was changed from

==========
Set up depot_tools as a recipe package, and add depot_tools recipe module.

This is a good prototypical example of how to do it :-).

BUG=564920
R=iannucci@chromium.org,martiniss@chromium.org
==========

to

==========
Set up depot_tools as a recipe package, and add depot_tools recipe module.

This is a good prototypical example of how to do it :-).

TBR for OWNERS change for recipes.cfg.  

BUG=564920
R=iannucci@chromium.org,martiniss@chromium.org
TBR=phajdan.jr@chromium.org
==========

[luqui, 2015-12-04 23:07:13]

The CQ bit was checked by luqui@chromium.org

[commit-bot: I haz the power, 2015-12-04 23:30:39]

Description was changed from

==========
Set up depot_tools as a recipe package, and add depot_tools recipe module.

This is a good prototypical example of how to do it :-).

TBR for OWNERS change for recipes.cfg.  

BUG=564920
R=iannucci@chromium.org,martiniss@chromium.org
TBR=phajdan.jr@chromium.org
==========

to

==========
Set up depot_tools as a recipe package, and add depot_tools recipe module.

This is a good prototypical example of how to do it :-).

TBR for OWNERS change for recipes.cfg.  

BUG=564920
R=iannucci@chromium.org,martiniss@chromium.org
TBR=phajdan.jr@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=297851
==========

[commit-bot: I haz the power, 2015-12-04 23:30:40]

Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=297851