Add RSAPrivateKey::CreateFromKeypair()

crypto/rsa_private_key_nss.cc

Index: crypto/rsa_private_key_nss.cc
diff --git a/crypto/rsa_private_key_nss.cc b/crypto/rsa_private_key_nss.cc
index 3b8bd4489a2446265d54cebe845b5fe1947ffc29..3cefcbed8f4b007fc6db124c29d33ba8505ebed7 100644
--- a/crypto/rsa_private_key_nss.cc
+++ b/crypto/rsa_private_key_nss.cc
@@ -81,6 +81,16 @@ RSAPrivateKey* RSAPrivateKey::CreateSensitiveFromPrivateKeyInfo(
 }
 
 // static
+RSAPrivateKey* RSAPrivateKey::CreateFromKeypair(
+    SECKEYPrivateKeyStr* key,
+    SECKEYPublicKeyStr* public_key) {

[Ryan Sleevi, 2013/05/07 19:45:23]

From an API perspective, there should be a little bit more error handling to
ensure it's right:

DCHECK(key);
DCHECK(public_key);

if (SECKEY_GetPrivateKeyType(public_key) != rsaKey ||
    SECKEY_GetPrivateKeyType(private_key) != rsaKey)
  return NULL;

You could also ignore |public_key| entirely and use SECKEY_ConvertToPublicKey -
which will |only| work for RSA keys (and only if the CKA_MODULUS and
CKA_PUBLIC_EXPONENT are readable - but they should be for all but the dumbest of
PKCS#11 smart cards), which will at least "guarantee" that |key| and
|public_key| are pairwise consistent - which we currently guarantee for the
other create functions.

[Chris Masone, 2013/05/07 21:00:39]

Done.

+  RSAPrivateKey* copy = new RSAPrivateKey();
+  copy->key_ = SECKEY_CopyPrivateKey(key);
+  copy->public_key_ = SECKEY_CopyPublicKey(public_key);
+  return copy;
+}
+
+// static
 RSAPrivateKey* RSAPrivateKey::FindFromPublicKeyInfo(
     const std::vector<uint8>& input) {
   EnsureNSSInit();