Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1494083003: Reduce calls sites where both the GrDrawContext & GrRenderTarget are both passed (Closed)

Created:
5 years ago by robertphillips
Modified:
5 years ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Reduce calls sites where both the GrDrawContext & GrRenderTarget are both passed TBR=bsalomon@google.com Committed: https://skia.googlesource.com/skia/+/433625e67c61c3acce4fd95b3881493c9f4f2c7f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -47 lines) Patch
M include/gpu/GrDrawContext.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/GrAtlasTextContext.h View 2 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/GrAtlasTextContext.cpp View 8 chunks +8 lines, -10 lines 0 comments Download
M src/gpu/GrDrawContext.cpp View 3 chunks +3 lines, -4 lines 0 comments Download
M src/gpu/GrStencilAndCoverTextContext.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/gpu/GrStencilAndCoverTextContext.cpp View 6 chunks +10 lines, -12 lines 0 comments Download
M src/gpu/GrTextContext.h View 2 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/GrTextContext.cpp View 6 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
robertphillips
5 years ago (2015-12-03 21:15:05 UTC) #2
robertphillips
ping
5 years ago (2015-12-04 14:16:29 UTC) #3
joshualitt
On 2015/12/04 14:16:29, robertphillips wrote: > ping lol, was JUST about to lgtm.
5 years ago (2015-12-04 14:18:59 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1494083003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1494083003/1
5 years ago (2015-12-04 14:34:54 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-04 14:47:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1494083003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1494083003/1
5 years ago (2015-12-04 14:51:37 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/4393)
5 years ago (2015-12-04 14:52:38 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1494083003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1494083003/1
5 years ago (2015-12-04 14:57:36 UTC) #16
commit-bot: I haz the power
5 years ago (2015-12-04 14:58:18 UTC) #18
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/433625e67c61c3acce4fd95b3881493c9f4f2c7f

Powered by Google App Engine
This is Rietveld 408576698