ppapi/api/private/ppb_nacl_private.idl - Issue 149403005: Pepper: Make StartSelLdr asynchronous.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/api/private/ppb_nacl_private.idl

Issue 149403005: Pepper: Make StartSelLdr asynchronous. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: CompletionCallback cleanup in service_runtime Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ppapi/api/private/ppb_nacl_private.idl

diff --git a/ppapi/api/private/ppb_nacl_private.idl b/ppapi/api/private/ppb_nacl_private.idl

index c8ef073090a2c1e19c05111ae8dd60e85dc635c8..6dfbff7989d7829058dcc923a0b89dbf6ada2bd0 100644

--- a/ppapi/api/private/ppb_nacl_private.idl

+++ b/ppapi/api/private/ppb_nacl_private.idl

@@ -54,16 +54,17 @@ interface PPB_NaCl_Private {

* the nexe contribute to crash throttling statisics and whether nexe starts

* are throttled by crash throttling.

- PP_ExternalPluginResult LaunchSelLdr([in] PP_Instance instance,

- [in] str_t alleged_url,

- [in] PP_Bool uses_irt,

- [in] PP_Bool uses_ppapi,

- [in] PP_Bool enable_ppapi_dev,

- [in] PP_Bool enable_dyncode_syscalls,

- [in] PP_Bool enable_exception_handling,

- [in] PP_Bool enable_crash_throttling,

- [out] mem_t imc_handle,

- [out] PP_Var error_message);

+ void LaunchSelLdr([in] PP_Instance instance,

+ [in] str_t alleged_url,

+ [in] PP_Bool uses_irt,

+ [in] PP_Bool uses_ppapi,

+ [in] PP_Bool enable_ppapi_dev,

+ [in] PP_Bool enable_dyncode_syscalls,

+ [in] PP_Bool enable_exception_handling,

+ [in] PP_Bool enable_crash_throttling,

+ [out] mem_t imc_handle,

+ [out] PP_Var error_message,

+ [in] PP_CompletionCallback callback);

/* This function starts the IPC proxy so the nexe can communicate with the

* browser. Returns PP_EXTERNAL_PLUGIN_OK on success, otherwise a result code