Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1494003004: PPC: [fullcode] Switch passing of new.target to register. (Closed)

Created:
5 years ago by MTBrandyberry
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [fullcode] Switch passing of new.target to register. Port 440a42b74135b84c188d7db11f4c07678f53d0f3 Original commit message: This passes the new.target value in a register instead of through a side-channel via the construct stub. Note that this marks the last consumer of said side-channel and the special slot in the construct stub frame can be removed as a follow-up. R=mstarzinger@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com TEST=mjsunit/es6/regress/regress-new-target-context BUG= Committed: https://crrev.com/3950206fc25d324bfd8b13b1fe3724c0444411c6 Cr-Commit-Position: refs/heads/master@{#32585}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -39 lines) Patch
M src/full-codegen/ppc/full-codegen-ppc.cc View 5 chunks +25 lines, -39 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
MTBrandyberry
5 years ago (2015-12-03 15:57:04 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1494003004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1494003004/1
5 years ago (2015-12-03 16:02:37 UTC) #3
Michael Starzinger
LGTM. Thanks!
5 years ago (2015-12-03 16:11:07 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-03 16:46:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1494003004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1494003004/1
5 years ago (2015-12-03 18:18:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1494003004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1494003004/1
5 years ago (2015-12-03 18:45:50 UTC) #11
john.yan
lgtm
5 years ago (2015-12-03 18:49:22 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-03 19:37:57 UTC) #13
commit-bot: I haz the power
5 years ago (2015-12-03 19:38:36 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3950206fc25d324bfd8b13b1fe3724c0444411c6
Cr-Commit-Position: refs/heads/master@{#32585}

Powered by Google App Engine
This is Rietveld 408576698