Issue 14940018: we only need one fontmetrics, since the paint (and fontcache) now know explicitly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14940018: we only need one fontmetrics, since the paint (and fontcache) now know explicitly (Closed)

Created:
7 years, 7 months ago by reed1

Modified:
7 years, 7 months ago

Reviewers:

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

we only need one fontmetrics, since the paint (and fontcache) now know explicitly if they are horizontal or vertical. Committed: https://code.google.com/p/skia/source/detail?r=9058

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -14 lines)			Patch
M	src/core/SkGlyphCache.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/core/SkGlyphCache.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/core/SkPaint.cpp	View	3 chunks	+5 lines, -6 lines	0 comments	Download
M	src/core/SkScalerContext.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/core/SkScalerContext.cpp	View	1 chunk	+10 lines, -2 lines	0 comments	Download

Total messages: 1 (0 generated)

reed1

7 years, 7 months ago (2013-05-08 14:19:13 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 manually as r9058 (presubmit successful).