Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 1493993002: X87: [debugger] simplify reloc info for debug break slots. (Closed)

Created:
5 years ago by zhengxing.li
Modified:
5 years ago
Reviewers:
Weiliang, chunyang.dai, Yang
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [debugger] simplify reloc info for debug break slots. port 531dde9f80cb4e6aaa03083b42285c319a47867f (r32516) original commit message: The new step-in implementation no longer tries to predict the step-in target, so we don't need the arguments count nor call type anymore. BUG= Committed: https://crrev.com/93a5a8552ef8ca70a15ce3535c05002844b37476 Cr-Commit-Position: refs/heads/master@{#32540}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M src/debug/x87/debug-x87.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/x87/assembler-x87.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 24 (12 generated)
zhengxing.li
5 years ago (2015-12-03 02:35:04 UTC) #2
Weiliang
lgtm lgtm
5 years ago (2015-12-03 04:39:30 UTC) #5
Weiliang
lgtm
5 years ago (2015-12-03 04:39:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1493993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1493993002/1
5 years ago (2015-12-03 04:39:36 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/12531)
5 years ago (2015-12-03 05:14:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1493993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1493993002/1
5 years ago (2015-12-03 05:49:30 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/12536)
5 years ago (2015-12-03 06:15:53 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1493993002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1493993002/20001
5 years ago (2015-12-03 06:23:12 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/12539)
5 years ago (2015-12-03 06:51:09 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1493993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1493993002/1
5 years ago (2015-12-03 07:18:31 UTC) #21
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-03 07:51:48 UTC) #22
commit-bot: I haz the power
5 years ago (2015-12-03 07:52:42 UTC) #24
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/93a5a8552ef8ca70a15ce3535c05002844b37476
Cr-Commit-Position: refs/heads/master@{#32540}

Powered by Google App Engine
This is Rietveld 408576698