src/crankshaft/hydrogen-instructions.cc - Issue 1493983004: [crankshaft] Loads and stores to typed arrays have to reference the backing store holder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/crankshaft/hydrogen-instructions.cc

Issue 1493983004: [crankshaft] Loads and stores to typed arrays have to reference the backing store holder (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: updates Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/crankshaft/hydrogen-instructions.cc

diff --git a/src/crankshaft/hydrogen-instructions.cc b/src/crankshaft/hydrogen-instructions.cc

index 440d3d0faf339f39cf8b00186365938a4d8ba84b..38998e2f96b01a71a81b857ea7b7f39bbcaee5a4 100644

--- a/src/crankshaft/hydrogen-instructions.cc

+++ b/src/crankshaft/hydrogen-instructions.cc

@@ -3543,7 +3543,7 @@ HValue* HLoadKeyedGeneric::Canonicalize() {

HInstruction* index = HLoadKeyed::New(

block()->graph()->isolate(), block()->graph()->zone(),

block()->graph()->GetInvalidContext(), index_cache, key_load->key(),

- key_load->key(), key_load->elements_kind());

+ key_load->key(), nullptr, key_load->elements_kind());

map_check->InsertBefore(this);

index->InsertBefore(this);

return Prepend(new(block()->zone()) HLoadFieldByIndex(

« no previous file with comments | « src/crankshaft/hydrogen-instructions.h ('k') | src/crankshaft/ia32/lithium-ia32.h » ('j') | no next file with comments »