Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(817)

Side by Side Diff: src/crankshaft/ia32/lithium-ia32.h

Issue 1493983004: [crankshaft] Loads and stores to typed arrays have to reference the backing store holder (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: updates Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/crankshaft/hydrogen-instructions.cc ('k') | src/crankshaft/ia32/lithium-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_CRANKSHAFT_IA32_LITHIUM_IA32_H_ 5 #ifndef V8_CRANKSHAFT_IA32_LITHIUM_IA32_H_
6 #define V8_CRANKSHAFT_IA32_LITHIUM_IA32_H_ 6 #define V8_CRANKSHAFT_IA32_LITHIUM_IA32_H_
7 7
8 #include "src/crankshaft/hydrogen.h" 8 #include "src/crankshaft/hydrogen.h"
9 #include "src/crankshaft/lithium.h" 9 #include "src/crankshaft/lithium.h"
10 #include "src/crankshaft/lithium-allocator.h" 10 #include "src/crankshaft/lithium-allocator.h"
(...skipping 1572 matching lines...) Expand 10 before | Expand all | Expand 10 after
1583 1583
1584 class LLoadRoot final : public LTemplateInstruction<1, 0, 0> { 1584 class LLoadRoot final : public LTemplateInstruction<1, 0, 0> {
1585 public: 1585 public:
1586 DECLARE_CONCRETE_INSTRUCTION(LoadRoot, "load-root") 1586 DECLARE_CONCRETE_INSTRUCTION(LoadRoot, "load-root")
1587 DECLARE_HYDROGEN_ACCESSOR(LoadRoot) 1587 DECLARE_HYDROGEN_ACCESSOR(LoadRoot)
1588 1588
1589 Heap::RootListIndex index() const { return hydrogen()->index(); } 1589 Heap::RootListIndex index() const { return hydrogen()->index(); }
1590 }; 1590 };
1591 1591
1592 1592
1593 class LLoadKeyed final : public LTemplateInstruction<1, 2, 0> { 1593 class LLoadKeyed final : public LTemplateInstruction<1, 3, 0> {
1594 public: 1594 public:
1595 LLoadKeyed(LOperand* elements, LOperand* key) { 1595 LLoadKeyed(LOperand* elements, LOperand* key, LOperand* backing_store_owner) {
1596 inputs_[0] = elements; 1596 inputs_[0] = elements;
1597 inputs_[1] = key; 1597 inputs_[1] = key;
1598 inputs_[2] = backing_store_owner;
1598 } 1599 }
1599 LOperand* elements() { return inputs_[0]; } 1600 LOperand* elements() { return inputs_[0]; }
1600 LOperand* key() { return inputs_[1]; } 1601 LOperand* key() { return inputs_[1]; }
1602 LOperand* backing_store_owner() { return inputs_[2]; }
1601 ElementsKind elements_kind() const { 1603 ElementsKind elements_kind() const {
1602 return hydrogen()->elements_kind(); 1604 return hydrogen()->elements_kind();
1603 } 1605 }
1604 bool is_fixed_typed_array() const { 1606 bool is_fixed_typed_array() const {
1605 return hydrogen()->is_fixed_typed_array(); 1607 return hydrogen()->is_fixed_typed_array();
1606 } 1608 }
1607 1609
1608 DECLARE_CONCRETE_INSTRUCTION(LoadKeyed, "load-keyed") 1610 DECLARE_CONCRETE_INSTRUCTION(LoadKeyed, "load-keyed")
1609 DECLARE_HYDROGEN_ACCESSOR(LoadKeyed) 1611 DECLARE_HYDROGEN_ACCESSOR(LoadKeyed)
1610 1612
(...skipping 524 matching lines...) Expand 10 before | Expand all | Expand 10 after
2135 2137
2136 DECLARE_CONCRETE_INSTRUCTION(StoreNamedGeneric, "store-named-generic") 2138 DECLARE_CONCRETE_INSTRUCTION(StoreNamedGeneric, "store-named-generic")
2137 DECLARE_HYDROGEN_ACCESSOR(StoreNamedGeneric) 2139 DECLARE_HYDROGEN_ACCESSOR(StoreNamedGeneric)
2138 2140
2139 void PrintDataTo(StringStream* stream) override; 2141 void PrintDataTo(StringStream* stream) override;
2140 Handle<Object> name() const { return hydrogen()->name(); } 2142 Handle<Object> name() const { return hydrogen()->name(); }
2141 LanguageMode language_mode() { return hydrogen()->language_mode(); } 2143 LanguageMode language_mode() { return hydrogen()->language_mode(); }
2142 }; 2144 };
2143 2145
2144 2146
2145 class LStoreKeyed final : public LTemplateInstruction<0, 3, 0> { 2147 class LStoreKeyed final : public LTemplateInstruction<0, 4, 0> {
2146 public: 2148 public:
2147 LStoreKeyed(LOperand* obj, LOperand* key, LOperand* val) { 2149 LStoreKeyed(LOperand* obj, LOperand* key, LOperand* val,
2150 LOperand* backing_store_owner) {
2148 inputs_[0] = obj; 2151 inputs_[0] = obj;
2149 inputs_[1] = key; 2152 inputs_[1] = key;
2150 inputs_[2] = val; 2153 inputs_[2] = val;
2154 inputs_[3] = backing_store_owner;
2151 } 2155 }
2152 2156
2153 bool is_fixed_typed_array() const { 2157 bool is_fixed_typed_array() const {
2154 return hydrogen()->is_fixed_typed_array(); 2158 return hydrogen()->is_fixed_typed_array();
2155 } 2159 }
2156 LOperand* elements() { return inputs_[0]; } 2160 LOperand* elements() { return inputs_[0]; }
2157 LOperand* key() { return inputs_[1]; } 2161 LOperand* key() { return inputs_[1]; }
2158 LOperand* value() { return inputs_[2]; } 2162 LOperand* value() { return inputs_[2]; }
2163 LOperand* backing_store_owner() { return inputs_[3]; }
2159 ElementsKind elements_kind() const { 2164 ElementsKind elements_kind() const {
2160 return hydrogen()->elements_kind(); 2165 return hydrogen()->elements_kind();
2161 } 2166 }
2162 2167
2163 DECLARE_CONCRETE_INSTRUCTION(StoreKeyed, "store-keyed") 2168 DECLARE_CONCRETE_INSTRUCTION(StoreKeyed, "store-keyed")
2164 DECLARE_HYDROGEN_ACCESSOR(StoreKeyed) 2169 DECLARE_HYDROGEN_ACCESSOR(StoreKeyed)
2165 2170
2166 void PrintDataTo(StringStream* stream) override; 2171 void PrintDataTo(StringStream* stream) override;
2167 uint32_t base_offset() const { return hydrogen()->base_offset(); } 2172 uint32_t base_offset() const { return hydrogen()->base_offset(); }
2168 bool NeedsCanonicalization() { return hydrogen()->NeedsCanonicalization(); } 2173 bool NeedsCanonicalization() { return hydrogen()->NeedsCanonicalization(); }
(...skipping 625 matching lines...) Expand 10 before | Expand all | Expand 10 after
2794 DISALLOW_COPY_AND_ASSIGN(LChunkBuilder); 2799 DISALLOW_COPY_AND_ASSIGN(LChunkBuilder);
2795 }; 2800 };
2796 2801
2797 #undef DECLARE_HYDROGEN_ACCESSOR 2802 #undef DECLARE_HYDROGEN_ACCESSOR
2798 #undef DECLARE_CONCRETE_INSTRUCTION 2803 #undef DECLARE_CONCRETE_INSTRUCTION
2799 2804
2800 } // namespace internal 2805 } // namespace internal
2801 } // namespace v8 2806 } // namespace v8
2802 2807
2803 #endif // V8_CRANKSHAFT_IA32_LITHIUM_IA32_H_ 2808 #endif // V8_CRANKSHAFT_IA32_LITHIUM_IA32_H_
OLDNEW
« no previous file with comments | « src/crankshaft/hydrogen-instructions.cc ('k') | src/crankshaft/ia32/lithium-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698