Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Side by Side Diff: src/crankshaft/hydrogen-instructions.cc

Issue 1493983004: [crankshaft] Loads and stores to typed arrays have to reference the backing store holder (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: updates Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/crankshaft/hydrogen-instructions.h ('k') | src/crankshaft/ia32/lithium-ia32.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/crankshaft/hydrogen-instructions.h" 5 #include "src/crankshaft/hydrogen-instructions.h"
6 6
7 #include "src/base/bits.h" 7 #include "src/base/bits.h"
8 #include "src/base/safe_math.h" 8 #include "src/base/safe_math.h"
9 #include "src/crankshaft/hydrogen-infer-representation.h" 9 #include "src/crankshaft/hydrogen-infer-representation.h"
10 #include "src/double.h" 10 #include "src/double.h"
(...skipping 3525 matching lines...) Expand 10 before | Expand all | Expand 10 after
3536 if (names_cache->enumerable() == object()) { 3536 if (names_cache->enumerable() == object()) {
3537 HForInCacheArray* index_cache = 3537 HForInCacheArray* index_cache =
3538 names_cache->index_cache(); 3538 names_cache->index_cache();
3539 HCheckMapValue* map_check = HCheckMapValue::New( 3539 HCheckMapValue* map_check = HCheckMapValue::New(
3540 block()->graph()->isolate(), block()->graph()->zone(), 3540 block()->graph()->isolate(), block()->graph()->zone(),
3541 block()->graph()->GetInvalidContext(), object(), 3541 block()->graph()->GetInvalidContext(), object(),
3542 names_cache->map()); 3542 names_cache->map());
3543 HInstruction* index = HLoadKeyed::New( 3543 HInstruction* index = HLoadKeyed::New(
3544 block()->graph()->isolate(), block()->graph()->zone(), 3544 block()->graph()->isolate(), block()->graph()->zone(),
3545 block()->graph()->GetInvalidContext(), index_cache, key_load->key(), 3545 block()->graph()->GetInvalidContext(), index_cache, key_load->key(),
3546 key_load->key(), key_load->elements_kind()); 3546 key_load->key(), nullptr, key_load->elements_kind());
3547 map_check->InsertBefore(this); 3547 map_check->InsertBefore(this);
3548 index->InsertBefore(this); 3548 index->InsertBefore(this);
3549 return Prepend(new(block()->zone()) HLoadFieldByIndex( 3549 return Prepend(new(block()->zone()) HLoadFieldByIndex(
3550 object(), index)); 3550 object(), index));
3551 } 3551 }
3552 } 3552 }
3553 } 3553 }
3554 3554
3555 return this; 3555 return this;
3556 } 3556 }
(...skipping 1137 matching lines...) Expand 10 before | Expand all | Expand 10 after
4694 case HObjectAccess::kExternalMemory: 4694 case HObjectAccess::kExternalMemory:
4695 os << "[external-memory]"; 4695 os << "[external-memory]";
4696 break; 4696 break;
4697 } 4697 }
4698 4698
4699 return os << "@" << access.offset(); 4699 return os << "@" << access.offset();
4700 } 4700 }
4701 4701
4702 } // namespace internal 4702 } // namespace internal
4703 } // namespace v8 4703 } // namespace v8
OLDNEW
« no previous file with comments | « src/crankshaft/hydrogen-instructions.h ('k') | src/crankshaft/ia32/lithium-ia32.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698