Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Side by Side Diff: src/crankshaft/arm64/lithium-arm64.cc

Issue 1493983004: [crankshaft] Loads and stores to typed arrays have to reference the backing store holder (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: updates Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/crankshaft/arm64/lithium-arm64.h ('k') | src/crankshaft/hydrogen.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/crankshaft/arm64/lithium-arm64.h" 5 #include "src/crankshaft/arm64/lithium-arm64.h"
6 6
7 #include <sstream> 7 #include <sstream>
8 8
9 #include "src/crankshaft/arm64/lithium-codegen-arm64.h" 9 #include "src/crankshaft/arm64/lithium-codegen-arm64.h"
10 #include "src/crankshaft/hydrogen-osr.h" 10 #include "src/crankshaft/hydrogen-osr.h"
(...skipping 1677 matching lines...) Expand 10 before | Expand all | Expand 10 after
1688 } 1688 }
1689 return result; 1689 return result;
1690 } 1690 }
1691 } else { 1691 } else {
1692 DCHECK((instr->representation().IsInteger32() && 1692 DCHECK((instr->representation().IsInteger32() &&
1693 !IsDoubleOrFloatElementsKind(instr->elements_kind())) || 1693 !IsDoubleOrFloatElementsKind(instr->elements_kind())) ||
1694 (instr->representation().IsDouble() && 1694 (instr->representation().IsDouble() &&
1695 IsDoubleOrFloatElementsKind(instr->elements_kind()))); 1695 IsDoubleOrFloatElementsKind(instr->elements_kind())));
1696 1696
1697 LOperand* temp = instr->key()->IsConstant() ? NULL : TempRegister(); 1697 LOperand* temp = instr->key()->IsConstant() ? NULL : TempRegister();
1698 LInstruction* result = DefineAsRegister( 1698 LOperand* backing_store_owner = UseAny(instr->backing_store_owner());
1699 new(zone()) LLoadKeyedExternal(elements, key, temp)); 1699 LInstruction* result = DefineAsRegister(new (zone()) LLoadKeyedExternal(
1700 elements, key, backing_store_owner, temp));
1700 if (elements_kind == UINT32_ELEMENTS && 1701 if (elements_kind == UINT32_ELEMENTS &&
1701 !instr->CheckFlag(HInstruction::kUint32)) { 1702 !instr->CheckFlag(HInstruction::kUint32)) {
1702 result = AssignEnvironment(result); 1703 result = AssignEnvironment(result);
1703 } 1704 }
1704 return result; 1705 return result;
1705 } 1706 }
1706 } 1707 }
1707 1708
1708 1709
1709 LInstruction* LChunkBuilder::DoLoadKeyedGeneric(HLoadKeyedGeneric* instr) { 1710 LInstruction* LChunkBuilder::DoLoadKeyedGeneric(HLoadKeyedGeneric* instr) {
(...skipping 598 matching lines...) Expand 10 before | Expand all | Expand 10 after
2308 val = UseRegister(instr->value()); 2309 val = UseRegister(instr->value());
2309 temp = instr->key()->IsConstant() ? NULL : TempRegister(); 2310 temp = instr->key()->IsConstant() ? NULL : TempRegister();
2310 } 2311 }
2311 2312
2312 if (instr->is_fixed_typed_array()) { 2313 if (instr->is_fixed_typed_array()) {
2313 DCHECK((instr->value()->representation().IsInteger32() && 2314 DCHECK((instr->value()->representation().IsInteger32() &&
2314 !IsDoubleOrFloatElementsKind(instr->elements_kind())) || 2315 !IsDoubleOrFloatElementsKind(instr->elements_kind())) ||
2315 (instr->value()->representation().IsDouble() && 2316 (instr->value()->representation().IsDouble() &&
2316 IsDoubleOrFloatElementsKind(instr->elements_kind()))); 2317 IsDoubleOrFloatElementsKind(instr->elements_kind())));
2317 DCHECK(instr->elements()->representation().IsExternal()); 2318 DCHECK(instr->elements()->representation().IsExternal());
2318 return new(zone()) LStoreKeyedExternal(elements, key, val, temp); 2319 LOperand* backing_store_owner = UseAny(instr->backing_store_owner());
2320 return new (zone())
2321 LStoreKeyedExternal(elements, key, val, backing_store_owner, temp);
2319 2322
2320 } else if (instr->value()->representation().IsDouble()) { 2323 } else if (instr->value()->representation().IsDouble()) {
2321 DCHECK(instr->elements()->representation().IsTagged()); 2324 DCHECK(instr->elements()->representation().IsTagged());
2322 return new(zone()) LStoreKeyedFixedDouble(elements, key, val, temp); 2325 return new(zone()) LStoreKeyedFixedDouble(elements, key, val, temp);
2323 2326
2324 } else { 2327 } else {
2325 DCHECK(instr->elements()->representation().IsTagged()); 2328 DCHECK(instr->elements()->representation().IsTagged());
2326 DCHECK(instr->value()->representation().IsSmiOrTagged() || 2329 DCHECK(instr->value()->representation().IsSmiOrTagged() ||
2327 instr->value()->representation().IsInteger32()); 2330 instr->value()->representation().IsInteger32());
2328 return new(zone()) LStoreKeyedFixed(elements, key, val, temp); 2331 return new(zone()) LStoreKeyedFixed(elements, key, val, temp);
(...skipping 399 matching lines...) Expand 10 before | Expand all | Expand 10 after
2728 LOperand* context = UseFixed(instr->context(), cp); 2731 LOperand* context = UseFixed(instr->context(), cp);
2729 LOperand* function = UseRegisterAtStart(instr->function()); 2732 LOperand* function = UseRegisterAtStart(instr->function());
2730 LAllocateBlockContext* result = 2733 LAllocateBlockContext* result =
2731 new(zone()) LAllocateBlockContext(context, function); 2734 new(zone()) LAllocateBlockContext(context, function);
2732 return MarkAsCall(DefineFixed(result, cp), instr); 2735 return MarkAsCall(DefineFixed(result, cp), instr);
2733 } 2736 }
2734 2737
2735 2738
2736 } // namespace internal 2739 } // namespace internal
2737 } // namespace v8 2740 } // namespace v8
OLDNEW
« no previous file with comments | « src/crankshaft/arm64/lithium-arm64.h ('k') | src/crankshaft/hydrogen.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698