Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Side by Side Diff: src/crankshaft/arm/lithium-arm.h

Issue 1493983004: [crankshaft] Loads and stores to typed arrays have to reference the backing store holder (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: updates Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/code-stubs-hydrogen.cc ('k') | src/crankshaft/arm/lithium-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_CRANKSHAFT_ARM_LITHIUM_ARM_H_ 5 #ifndef V8_CRANKSHAFT_ARM_LITHIUM_ARM_H_
6 #define V8_CRANKSHAFT_ARM_LITHIUM_ARM_H_ 6 #define V8_CRANKSHAFT_ARM_LITHIUM_ARM_H_
7 7
8 #include "src/crankshaft/hydrogen.h" 8 #include "src/crankshaft/hydrogen.h"
9 #include "src/crankshaft/lithium.h" 9 #include "src/crankshaft/lithium.h"
10 #include "src/crankshaft/lithium-allocator.h" 10 #include "src/crankshaft/lithium-allocator.h"
(...skipping 1584 matching lines...) Expand 10 before | Expand all | Expand 10 after
1595 1595
1596 class LLoadRoot final : public LTemplateInstruction<1, 0, 0> { 1596 class LLoadRoot final : public LTemplateInstruction<1, 0, 0> {
1597 public: 1597 public:
1598 DECLARE_CONCRETE_INSTRUCTION(LoadRoot, "load-root") 1598 DECLARE_CONCRETE_INSTRUCTION(LoadRoot, "load-root")
1599 DECLARE_HYDROGEN_ACCESSOR(LoadRoot) 1599 DECLARE_HYDROGEN_ACCESSOR(LoadRoot)
1600 1600
1601 Heap::RootListIndex index() const { return hydrogen()->index(); } 1601 Heap::RootListIndex index() const { return hydrogen()->index(); }
1602 }; 1602 };
1603 1603
1604 1604
1605 class LLoadKeyed final : public LTemplateInstruction<1, 2, 0> { 1605 class LLoadKeyed final : public LTemplateInstruction<1, 3, 0> {
1606 public: 1606 public:
1607 LLoadKeyed(LOperand* elements, LOperand* key) { 1607 LLoadKeyed(LOperand* elements, LOperand* key, LOperand* backing_store_owner) {
1608 inputs_[0] = elements; 1608 inputs_[0] = elements;
1609 inputs_[1] = key; 1609 inputs_[1] = key;
1610 inputs_[2] = backing_store_owner;
1610 } 1611 }
1611 1612
1612 LOperand* elements() { return inputs_[0]; } 1613 LOperand* elements() { return inputs_[0]; }
1613 LOperand* key() { return inputs_[1]; } 1614 LOperand* key() { return inputs_[1]; }
1615 LOperand* backing_store_owner() { return inputs_[2]; }
1614 ElementsKind elements_kind() const { 1616 ElementsKind elements_kind() const {
1615 return hydrogen()->elements_kind(); 1617 return hydrogen()->elements_kind();
1616 } 1618 }
1617 bool is_fixed_typed_array() const { 1619 bool is_fixed_typed_array() const {
1618 return hydrogen()->is_fixed_typed_array(); 1620 return hydrogen()->is_fixed_typed_array();
1619 } 1621 }
1620 1622
1621 DECLARE_CONCRETE_INSTRUCTION(LoadKeyed, "load-keyed") 1623 DECLARE_CONCRETE_INSTRUCTION(LoadKeyed, "load-keyed")
1622 DECLARE_HYDROGEN_ACCESSOR(LoadKeyed) 1624 DECLARE_HYDROGEN_ACCESSOR(LoadKeyed)
1623 1625
(...skipping 518 matching lines...) Expand 10 before | Expand all | Expand 10 after
2142 DECLARE_CONCRETE_INSTRUCTION(StoreNamedGeneric, "store-named-generic") 2144 DECLARE_CONCRETE_INSTRUCTION(StoreNamedGeneric, "store-named-generic")
2143 DECLARE_HYDROGEN_ACCESSOR(StoreNamedGeneric) 2145 DECLARE_HYDROGEN_ACCESSOR(StoreNamedGeneric)
2144 2146
2145 void PrintDataTo(StringStream* stream) override; 2147 void PrintDataTo(StringStream* stream) override;
2146 2148
2147 Handle<Object> name() const { return hydrogen()->name(); } 2149 Handle<Object> name() const { return hydrogen()->name(); }
2148 LanguageMode language_mode() { return hydrogen()->language_mode(); } 2150 LanguageMode language_mode() { return hydrogen()->language_mode(); }
2149 }; 2151 };
2150 2152
2151 2153
2152 class LStoreKeyed final : public LTemplateInstruction<0, 3, 0> { 2154 class LStoreKeyed final : public LTemplateInstruction<0, 4, 0> {
2153 public: 2155 public:
2154 LStoreKeyed(LOperand* object, LOperand* key, LOperand* value) { 2156 LStoreKeyed(LOperand* object, LOperand* key, LOperand* value,
2157 LOperand* backing_store_owner) {
2155 inputs_[0] = object; 2158 inputs_[0] = object;
2156 inputs_[1] = key; 2159 inputs_[1] = key;
2157 inputs_[2] = value; 2160 inputs_[2] = value;
2161 inputs_[3] = backing_store_owner;
2158 } 2162 }
2159 2163
2160 bool is_fixed_typed_array() const { 2164 bool is_fixed_typed_array() const {
2161 return hydrogen()->is_fixed_typed_array(); 2165 return hydrogen()->is_fixed_typed_array();
2162 } 2166 }
2163 LOperand* elements() { return inputs_[0]; } 2167 LOperand* elements() { return inputs_[0]; }
2164 LOperand* key() { return inputs_[1]; } 2168 LOperand* key() { return inputs_[1]; }
2165 LOperand* value() { return inputs_[2]; } 2169 LOperand* value() { return inputs_[2]; }
2170 LOperand* backing_store_owner() { return inputs_[3]; }
2166 ElementsKind elements_kind() const { 2171 ElementsKind elements_kind() const {
2167 return hydrogen()->elements_kind(); 2172 return hydrogen()->elements_kind();
2168 } 2173 }
2169 2174
2170 DECLARE_CONCRETE_INSTRUCTION(StoreKeyed, "store-keyed") 2175 DECLARE_CONCRETE_INSTRUCTION(StoreKeyed, "store-keyed")
2171 DECLARE_HYDROGEN_ACCESSOR(StoreKeyed) 2176 DECLARE_HYDROGEN_ACCESSOR(StoreKeyed)
2172 2177
2173 void PrintDataTo(StringStream* stream) override; 2178 void PrintDataTo(StringStream* stream) override;
2174 bool NeedsCanonicalization() { 2179 bool NeedsCanonicalization() {
2175 if (hydrogen()->value()->IsAdd() || hydrogen()->value()->IsSub() || 2180 if (hydrogen()->value()->IsAdd() || hydrogen()->value()->IsSub() ||
(...skipping 618 matching lines...) Expand 10 before | Expand all | Expand 10 after
2794 DISALLOW_COPY_AND_ASSIGN(LChunkBuilder); 2799 DISALLOW_COPY_AND_ASSIGN(LChunkBuilder);
2795 }; 2800 };
2796 2801
2797 #undef DECLARE_HYDROGEN_ACCESSOR 2802 #undef DECLARE_HYDROGEN_ACCESSOR
2798 #undef DECLARE_CONCRETE_INSTRUCTION 2803 #undef DECLARE_CONCRETE_INSTRUCTION
2799 2804
2800 } // namespace internal 2805 } // namespace internal
2801 } // namespace v8 2806 } // namespace v8
2802 2807
2803 #endif // V8_CRANKSHAFT_ARM_LITHIUM_ARM_H_ 2808 #endif // V8_CRANKSHAFT_ARM_LITHIUM_ARM_H_
OLDNEW
« no previous file with comments | « src/code-stubs-hydrogen.cc ('k') | src/crankshaft/arm/lithium-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698