[turbofan] Make RawMachineAssembler handle the end node.

[turbofan] Make RawMachineAssembler handle the end node.

This moves the proper handling for the end node withing the constructed
graph into the RawMachineAssembler. This simplifies all assemblers and
makes the handling of {Start} and {End} symmetrical.

R=bmeurer@chromium.org

Committed: https://crrev.com/33142c120d92a1604eb48e6c24b2f8d5c9692bd4
Cr-Commit-Position: refs/heads/master@{#32563}

[Michael Starzinger, 2015-12-03 12:28:27]

https://codereview.chromium.org/1493963003/diff/1/src/compiler/raw-machine-as...
File src/compiler/raw-machine-assembler.cc (right):

https://codereview.chromium.org/1493963003/diff/1/src/compiler/raw-machine-as...
src/compiler/raw-machine-assembler.cc:35: graph->SetEnd(UndefinedConstant());
This is a dirty hack because currently we disallow {End} nodes with zero inputs
and I hijack the undefined constant as some random node with zero inputs.
However I am unsure whether we should relax the check in
CommonOperatorBuilder::End that disallows it. WDYT?

[Benedikt Meurer, 2015-12-03 12:49:16]

LGTM

https://codereview.chromium.org/1493963003/diff/1/src/compiler/raw-machine-as...
File src/compiler/raw-machine-assembler.cc (right):

https://codereview.chromium.org/1493963003/diff/1/src/compiler/raw-machine-as...
src/compiler/raw-machine-assembler.cc:35: graph->SetEnd(UndefinedConstant());
As discussed, remove the hack and use End(0)

[Michael Starzinger, 2015-12-03 12:53:32]

Danno, Orion & Daniel: FYI.

https://codereview.chromium.org/1493963003/diff/1/src/compiler/raw-machine-as...
File src/compiler/raw-machine-assembler.cc (right):

https://codereview.chromium.org/1493963003/diff/1/src/compiler/raw-machine-as...
src/compiler/raw-machine-assembler.cc:35: graph->SetEnd(UndefinedConstant());
On 2015/12/03 12:49:15, Benedikt Meurer wrote:
> As discussed, remove the hack and use End(0)

Done.

[Michael Starzinger, 2015-12-03 13:09:29]

The CQ bit was checked by mstarzinger@chromium.org

[Michael Starzinger, 2015-12-03 13:09:30]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/1493963003/#ps20001
(title: "Addressed comment.")

[commit-bot: I haz the power, 2015-12-03 13:09:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1493963003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1493963003/20001

[commit-bot: I haz the power, 2015-12-03 13:29:32]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-03 13:30:13]

Description was changed from

==========
[turbofan] Make RawMachineAssembler handle the end node.

This moves the proper handling for the end node withing the constructed
graph into the RawMachineAssembler. This simplifies all assemblers and
makes the handling of {Start} and {End} symmetrical.

R=bmeurer@chromium.org
==========

to

==========
[turbofan] Make RawMachineAssembler handle the end node.

This moves the proper handling for the end node withing the constructed
graph into the RawMachineAssembler. This simplifies all assemblers and
makes the handling of {Start} and {End} symmetrical.

R=bmeurer@chromium.org

Committed: https://crrev.com/33142c120d92a1604eb48e6c24b2f8d5c9692bd4
Cr-Commit-Position: refs/heads/master@{#32563}
==========

[commit-bot: I haz the power, 2015-12-03 13:30:14]

Patchset 2 (id:??) landed as
https://crrev.com/33142c120d92a1604eb48e6c24b2f8d5c9692bd4
Cr-Commit-Position: refs/heads/master@{#32563}