Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 149393009: Fixes possible crash in tab dragging (Closed)

Created:
6 years, 10 months ago by sky
Modified:
6 years, 10 months ago
CC:
chromium-reviews, tfarina, dcheng
Visibility:
Public.

Description

Fixes possible crash in tab dragging Crash would occur in resetting selection model. It was possible to attempt to reset the selection model with an active index of -1, which TabStripModel does not like. BUG=338285 TEST=see bug R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247868

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -14 lines) Patch
M chrome/browser/ui/views/tabs/tab_drag_controller.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller.cc View 2 chunks +26 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sky
Test will have to wait until I refactor for better testing.
6 years, 10 months ago (2014-01-29 23:02:52 UTC) #1
Ben Goodger (Google)
lgtm
6 years, 10 months ago (2014-01-29 23:16:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/149393009/1
6 years, 10 months ago (2014-01-29 23:43:40 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) app_list_unittests, ash_unittests, aura_unittests, cacheinvalidation_unittests, cc_unittests, check_deps, ...
6 years, 10 months ago (2014-01-30 00:34:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/149393009/1
6 years, 10 months ago (2014-01-30 04:25:40 UTC) #5
commit-bot: I haz the power
6 years, 10 months ago (2014-01-30 07:18:42 UTC) #6
Message was sent while issue was closed.
Change committed as 247868

Powered by Google App Engine
This is Rietveld 408576698