Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 149393004: Revert of Unify desktop and Android tab helper instantiation. (Closed)

Created:
6 years, 10 months ago by cimamoglu (inactive)
Modified:
6 years, 10 months ago
CC:
chromium-reviews, tburkard+watch_chromium.org, gavinp+prer_chromium.org, cbentzel+watch_chromium.org, dominich+watch_chromium.org, davidben+watch_chromium.org
Visibility:
Public.

Description

Revert of Unify desktop and Android tab helper instantiation. (https://codereview.chromium.org/144443003/) Reason for revert: This causes Clank to crash at startup, and makes tests fail http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/11575 Tried the revert locally, and Clank started normally. Original issue's description: > Unify desktop and Android tab helper instantiation. > > BUG=337600 > TEST=zero visible change > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247676 TBR=yfriedman@chromium.org,jam@chromium.org,avi@chromium.org NOTREECHECKS=true NOTRY=true BUG=337600 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247682

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+365 lines, -291 lines) Patch
M chrome/browser/android/chrome_web_contents_delegate_android.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/android/tab_android.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/android/tab_android.cc View 2 chunks +94 lines, -3 lines 0 comments Download
M chrome/browser/prerender/prerender_contents.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_navigator.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A chrome/browser/ui/browser_tab_contents.h View 1 chunk +56 lines, -0 lines 0 comments Download
A chrome/browser/ui/browser_tab_contents.cc View 1 chunk +199 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser_tab_strip_model_delegate.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D chrome/browser/ui/tab_helpers.h View 1 chunk +0 lines, -60 lines 0 comments Download
D chrome/browser/ui/tab_helpers.cc View 1 chunk +0 lines, -215 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
cimamoglu (inactive)
Created Revert of Unify desktop and Android tab helper instantiation.
6 years, 10 months ago (2014-01-29 13:36:25 UTC) #1
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 10 months ago (2014-01-29 13:36:35 UTC) #2
cimamoglu (inactive)
+whywhat for LGTM
6 years, 10 months ago (2014-01-29 13:39:59 UTC) #3
whywhat
lgtm
6 years, 10 months ago (2014-01-29 13:41:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cimamoglu@chromium.org/149393004/1
6 years, 10 months ago (2014-01-29 13:41:54 UTC) #5
commit-bot: I haz the power
Change committed as 247682
6 years, 10 months ago (2014-01-29 13:42:14 UTC) #6
Avi (use Gerrit)
On 2014/01/29 13:42:14, I haz the power (commit-bot) wrote: > Change committed as 247682 The ...
6 years, 10 months ago (2014-01-29 16:49:41 UTC) #7
Yaron
On 2014/01/29 16:49:41, Avi wrote: > On 2014/01/29 13:42:14, I haz the power (commit-bot) wrote: ...
6 years, 10 months ago (2014-01-29 17:20:26 UTC) #8
Avi (use Gerrit)
On 2014/01/29 17:20:26, Yaron wrote: > On 2014/01/29 16:49:41, Avi wrote: > > On 2014/01/29 ...
6 years, 10 months ago (2014-01-29 17:22:56 UTC) #9
Yaron
Damn. Sorry I missed it.
6 years, 10 months ago (2014-01-29 17:29:08 UTC) #10
Avi (use Gerrit)
6 years, 10 months ago (2014-01-29 17:44:40 UTC) #11
Message was sent while issue was closed.
On 2014/01/29 17:29:08, Yaron wrote:
> Damn. Sorry I missed it.

No problem. I kept pushing the commit button on the CQ when the Android bot was
repeatedly freaking out, so I don't come out smelling too sweet here, either.

The new version is going through the trybots on
https://codereview.chromium.org/144443003/ . We'll see how it goes.

Powered by Google App Engine
This is Rietveld 408576698