VideoCapturerAndroid, handle cvo correctly

talk/app/webrtc/java/jni/androidvideocapturer_jni.h

 /*
  * libjingle
  * Copyright 2015 Google Inc.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are met:
  *
  *  1. Redistributions of source code must retain the above copyright notice,
  *     this list of conditions and the following disclaimer.
  *  2. Redistributions in binary form must reproduce the above copyright notice,
@@ skipping 42 matching lines @@
   void Start(int width, int height, int framerate,
              webrtc::AndroidVideoCapturer* capturer) override;
   void Stop() override;
 
   std::string GetSupportedFormats() override;
 
   // Called from VideoCapturerAndroid::NativeObserver on a Java thread.
   void OnCapturerStarted(bool success);
   void OnMemoryBufferFrame(void* video_frame, int length, int width,
                            int height, int rotation, int64_t timestamp_ns);
-  void OnTextureFrame(int width, int height, int64_t timestamp_ns,
+  void OnTextureFrame(int width, int height, int rotation, int64_t timestamp_ns,

[nisse-chromium (ooo August 14), 2015/12/08 08:46:34]

The rotation has to be one of the values in webrtc::VideoRotation, right?

It's a bit unclear in this interface if it is intended as an arbitrary angle
(and if so, what unit and direction), which happens to be only partially
implemented, or if it should be treated more like an enum.

I think it needs a comment, and some error handling in case an unexpected value
is received.

[perkj_chrome, 2015/12/09 21:00:40]

It is the same as OnMemoryBufferFrame and  is checked in
AndroidVideoCapturer::FrameFactory::UpdateCapturedFrame

[nisse-chromium (ooo August 14), 2015/12/10 09:04:57]

I see.

                       const NativeHandleImpl& handle);
   void OnOutputFormatRequest(int width, int height, int fps);
 
  protected:
   ~AndroidVideoCapturerJni();
 
  private:
   void ReturnBuffer(int64_t time_stamp);
   JNIEnv* jni();
 
@@ skipping 27 matching lines @@
   rtc::scoped_ptr<rtc::GuardedAsyncInvoker> invoker_ GUARDED_BY(capturer_lock_);
 
   static jobject application_context_;
 
   RTC_DISALLOW_COPY_AND_ASSIGN(AndroidVideoCapturerJni);
 };
 
 }  // namespace webrtc_jni
 
 #endif  // TALK_APP_WEBRTC_JAVA_JNI_ANDROIDVIDEOCAPTURER_JNI_H_