Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 1493913005: [CT+DM] Change location of SKPs dir to outside checkouts (Closed)

Created:
5 years ago by rmistry
Modified:
5 years ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[CT+DM] Change location of SKPs dir to outside checkouts. BUG=skia:2545 TBR=phajdan Committed: https://crrev.com/541795c147e6a27c93da6a60a40574c0f2914829 Cr-Commit-Position: refs/heads/master@{#363043}

Patch Set 1 : Initial upload #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M chrome/ct_dm.isolate View 1 1 chunk +1 line, -1 line 0 comments Download
A content/test/ct/OWNERS View 1 chunk +4 lines, -0 lines 0 comments Download
M content/test/ct/run_ct_dm.py View 1 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 24 (12 generated)
rmistry
5 years ago (2015-12-03 17:18:21 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1493913005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1493913005/20001
5 years ago (2015-12-03 18:40:36 UTC) #5
commit-bot: I haz the power
Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even ...
5 years ago (2015-12-03 18:40:37 UTC) #7
M-A Ruel
lgtm
5 years ago (2015-12-03 18:50:39 UTC) #8
M-A Ruel
lgtm
5 years ago (2015-12-03 18:52:30 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1493913005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1493913005/20001
5 years ago (2015-12-03 18:54:06 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/124653)
5 years ago (2015-12-03 19:05:23 UTC) #13
rmistry
+Pawel for content/test/... files. TBR'ing for now.
5 years ago (2015-12-03 19:40:03 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1493913005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1493913005/20001
5 years ago (2015-12-03 19:40:48 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-03 20:22:23 UTC) #20
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/541795c147e6a27c93da6a60a40574c0f2914829 Cr-Commit-Position: refs/heads/master@{#363043}
5 years ago (2015-12-03 20:23:12 UTC) #22
Paweł Hajdan Jr.
5 years ago (2015-12-04 09:13:29 UTC) #24
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698