third_party/WebKit/Source/core/inspector/CodeGeneratorInspector.py - Issue 1493913004: Remove IsPointerConvertible trait and hacks and just use std::is_base_of.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/CodeGeneratorInspector.py

Issue 1493913004: Remove IsPointerConvertible trait and hacks and just use std::is_base_of. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix #if cond Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/LayoutTreeBuilderTraversal.h ('k') | third_party/WebKit/Source/modules/indexeddb/IDBAny.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/CodeGeneratorInspector.py

diff --git a/third_party/WebKit/Source/core/inspector/CodeGeneratorInspector.py b/third_party/WebKit/Source/core/inspector/CodeGeneratorInspector.py

index 8a707bccc294323f86158885139f3c0cf9a4c152..43091f30c15017d076d65ee25e6071ee2fe49c9f 100755

--- a/third_party/WebKit/Source/core/inspector/CodeGeneratorInspector.py

+++ b/third_party/WebKit/Source/core/inspector/CodeGeneratorInspector.py

@@ -1145,7 +1145,7 @@ class TypeBindings:

@staticmethod

def get_setter_value_expression_pattern():

- return None

+ return "static_pointer_cast<JSONValue>(%s)"

@staticmethod

def reduce_to_raw_type():