Issue 1493893007: GN: Fix placeholders having double .so extension and breaking rezip

Issue 1493893007: GN: Fix placeholders having double .so extension and breaking rezip (Closed)

Created:
5 years ago by agrieve

Modified:
5 years ago

Reviewers:
Yaron

CC:
chromium-reviews, klundberg+watch_chromium.org, mikecase+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

GN: Fix placeholders having double .so extension and breaking rezip BUG=552040 Committed: https://crrev.com/0877e82ad78019ca0483e7122c0011c1d53814ae Cr-Commit-Position: refs/heads/master@{#363023}

Patch Set 1 #

Created: 5 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	build/android/gyp/apkbuilder.py	View		1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 10 (5 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

agrieve

On 2015/12/03 16:50:59, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:yfriedman@chromium.org ☺ ☻

5 years ago (2015-12-03 16:51:06 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1493893007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1493893007/1

5 years ago (2015-12-03 17:03:41 UTC) #6

commit-bot: I haz the power

5 years ago (2015-12-03 18:56:01 UTC) #10

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/0877e82ad78019ca0483e7122c0011c1d53814ae
Cr-Commit-Position: refs/heads/master@{#363023}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages