Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 1493893006: Include tokens of Function/MethodDeclaration into AST view. (Closed)

Created:
5 years ago by scheglov
Modified:
5 years ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Include tokens of Function/MethodDeclaration into AST view. It helped to identify the "The null object does not have a getter 'variable'" problem. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/93072d7825e7ebc40cd33dba2cb825bb1866cc15

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M pkg/analysis_server/lib/src/status/ast_writer.dart View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
5 years ago (2015-12-03 16:42:01 UTC) #1
Brian Wilkerson
LGTM
5 years ago (2015-12-03 16:54:37 UTC) #2
scheglov
5 years ago (2015-12-03 18:00:10 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
93072d7825e7ebc40cd33dba2cb825bb1866cc15 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698