Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 1493883002: Add layout test canvas/synchronous-create-pattern.html back (Closed)

Created:
5 years ago by xidachen
Modified:
5 years ago
Reviewers:
pdr.
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add layout test canvas/synchronous-create-pattern.html back This layout test tests createPattern operates synchronously with an animated image. The test was removed because it was using SVG animation which was flacky. This CL changes the SVG animation to CSS animation. BUG=316730 Committed: https://crrev.com/df0570128761cd67da25eb2e5ea33bfa7dc7e266 Cr-Commit-Position: refs/heads/master@{#362919}

Patch Set 1 #

Total comments: 1

Patch Set 2 : better testing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -13 lines) Patch
A + third_party/WebKit/LayoutTests/canvas/resources/green-flash-at-50ms.svg View 1 1 chunk +6 lines, -7 lines 0 comments Download
A third_party/WebKit/LayoutTests/canvas/synchronous-create-pattern.html View 1 1 chunk +45 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/canvas/synchronous-create-pattern-expected.html View 1 1 chunk +9 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
xidachen
I tried with --iteration=1000 and it passed all the time. https://codereview.chromium.org/1493883002/diff/1/third_party/WebKit/LayoutTests/canvas/synchronous-create-pattern.html File third_party/WebKit/LayoutTests/canvas/synchronous-create-pattern.html (right): https://codereview.chromium.org/1493883002/diff/1/third_party/WebKit/LayoutTests/canvas/synchronous-create-pattern.html#newcode20 ...
5 years ago (2015-12-02 19:38:23 UTC) #2
pdr.
This doesn't quite test what we want to test, but it's close. This test should ...
5 years ago (2015-12-02 23:14:16 UTC) #3
xidachen
On 2015/12/02 23:14:16, pdr wrote: > This doesn't quite test what we want to test, ...
5 years ago (2015-12-03 02:10:28 UTC) #4
pdr.
Looks great! LGTM :)
5 years ago (2015-12-03 04:53:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1493883002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1493883002/20001
5 years ago (2015-12-03 04:53:42 UTC) #7
xidachen
On 2015/12/03 04:53:03, pdr wrote: > Looks great! LGTM :) Thanks for your help!
5 years ago (2015-12-03 04:55:30 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-03 05:50:10 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-03 05:50:54 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/df0570128761cd67da25eb2e5ea33bfa7dc7e266
Cr-Commit-Position: refs/heads/master@{#362919}

Powered by Google App Engine
This is Rietveld 408576698