Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 1493863004: Revert of [debugger] do not restart frames that reference new.target for liveedit. (Closed)

Created:
5 years ago by Michael Achenbach
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [debugger] do not restart frames that reference new.target for liveedit. (patchset #1 id:1 of https://codereview.chromium.org/1493363002/ ) Reason for revert: [Sheriff] Speculative revert for https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/3225 Original issue's description: > [debugger] do not restart frames that reference new.target for liveedit. > > R=mstarzinger@chromium.org > > Committed: https://crrev.com/6fca870240bdbb07a365189b5eb0c98fa65b3682 > Cr-Commit-Position: refs/heads/master@{#32572} TBR=mstarzinger@chromium.org,yangguo@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/1a61dab34b9849f3f70a42ce69317e22758c53a1 Cr-Commit-Position: refs/heads/master@{#32582}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -403 lines) Patch
M src/ast/scopeinfo.cc View 3 chunks +0 lines, -6 lines 0 comments Download
M src/debug/arm/debug-arm.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/debug/arm64/debug-arm64.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/debug/ia32/debug-ia32.cc View 1 chunk +4 lines, -7 lines 0 comments Download
M src/debug/liveedit.h View 2 chunks +2 lines, -4 lines 0 comments Download
M src/debug/liveedit.cc View 10 chunks +35 lines, -94 lines 0 comments Download
M src/debug/liveedit.js View 4 chunks +19 lines, -28 lines 0 comments Download
M src/debug/mips/debug-mips.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/debug/mips64/debug-mips64.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/debug/x64/debug-x64.cc View 1 chunk +4 lines, -7 lines 0 comments Download
M src/objects.h View 2 chunks +2 lines, -6 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-liveedit.cc View 1 chunk +13 lines, -25 lines 0 comments Download
D test/mjsunit/es6/debug-liveedit-new-target-1.js View 1 chunk +0 lines, -75 lines 0 comments Download
D test/mjsunit/es6/debug-liveedit-new-target-2.js View 1 chunk +0 lines, -63 lines 0 comments Download
D test/mjsunit/es6/debug-liveedit-new-target-3.js View 1 chunk +0 lines, -73 lines 0 comments Download
M test/mjsunit/regress/regress-crbug-390925.js View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Michael Achenbach
Created Revert of [debugger] do not restart frames that reference new.target for liveedit.
5 years ago (2015-12-03 18:38:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1493863004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1493863004/1
5 years ago (2015-12-03 18:38:26 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-03 18:38:50 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1a61dab34b9849f3f70a42ce69317e22758c53a1 Cr-Commit-Position: refs/heads/master@{#32582}
5 years ago (2015-12-03 18:39:26 UTC) #5
Michael Achenbach
This was very speculative. Might be any other commit in the range.
5 years ago (2015-12-03 18:40:54 UTC) #6
Yang
On 2015/12/03 18:40:54, Michael Achenbach (slow) wrote: > This was very speculative. Might be any ...
5 years ago (2015-12-03 19:18:16 UTC) #7
Michael Achenbach
5 years ago (2015-12-03 20:20:59 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1492393003/ by machenbach@chromium.org.

The reason for reverting is: Didn't help....

Powered by Google App Engine
This is Rietveld 408576698