Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 1493833003: Issue 25050. Fix for NPE in ConstantEvaluationEngine when duplicate fields. (Closed)

Created:
5 years ago by scheglov
Modified:
5 years ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -1 line) Patch
M pkg/analyzer/lib/src/generated/constant.dart View 2 chunks +8 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/task/dart_test.dart View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
5 years ago (2015-12-02 19:25:09 UTC) #1
Brian Wilkerson
LGTM
5 years ago (2015-12-02 19:28:54 UTC) #2
scheglov
5 years ago (2015-12-02 19:29:41 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f12da4d00c2134b9d60d9657a77d4263c197271a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698