Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 149383002: Clean-up: Replace Canvas::DrawStringInt with DrawStringRect. (Closed)

Created:
6 years, 10 months ago by Yuki
Modified:
6 years, 10 months ago
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org, tfarina
Visibility:
Public.

Description

Clean-up: Replace Canvas::DrawStringInt with DrawStringRect. As part of effort to support multiple fonts, this CL changes methods which are now taking gfx::Font so they will take gfx::FontList instead. See https://docs.google.com/a/chromium.org/document/d/1D_25fp9B8b9aZJORfAjDIFq61NWvUquZ5xmKH-VcC4k/view BUG=265485 TEST=Run unit_tests, ui_unittests, views_unittests. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247920

Patch Set 1 #

Patch Set 2 : Synced. #

Patch Set 3 : Fixed the build break. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -28 lines) Patch
M ash/shell/app_list.cc View 1 2 2 chunks +8 lines, -8 lines 0 comments Download
M ash/shell/lock_view.cc View 3 chunks +10 lines, -7 lines 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_utils_gtk.cc View 3 chunks +6 lines, -9 lines 0 comments Download
M ui/views/controls/menu/menu_item_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/examples/text_example.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Yuki
Could you guys review this CL? jamescook: ash/shell/ erg: chrome/browser/ui/gtk/ sadrul: ui/views/
6 years, 10 months ago (2014-01-29 08:03:08 UTC) #1
James Cook
ash/* LGTM Thanks for linking the design doc!
6 years, 10 months ago (2014-01-29 17:43:16 UTC) #2
Elliot Glaysher
gtk lgtm
6 years, 10 months ago (2014-01-29 18:20:02 UTC) #3
sadrul
LGTM
6 years, 10 months ago (2014-01-29 18:22:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukishiino@chromium.org/149383002/1
6 years, 10 months ago (2014-01-30 02:44:09 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=254014
6 years, 10 months ago (2014-01-30 03:40:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukishiino@chromium.org/149383002/40001
6 years, 10 months ago (2014-01-30 05:20:23 UTC) #7
commit-bot: I haz the power
Retried try job too often on android_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_dbg&number=144579
6 years, 10 months ago (2014-01-30 07:18:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukishiino@chromium.org/149383002/40001
6 years, 10 months ago (2014-01-30 07:45:15 UTC) #9
commit-bot: I haz the power
6 years, 10 months ago (2014-01-30 10:25:19 UTC) #10
Message was sent while issue was closed.
Change committed as 247920

Powered by Google App Engine
This is Rietveld 408576698