tools/clang/plugins/tests/base_refcounted.h - Issue 1493813003: Convert the no-inline-virtuals rule into a constructors rule.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/clang/plugins/tests/base_refcounted.h

Issue 1493813003: Convert the no-inline-virtuals rule into a constructors rule. Base URL: https://chromium.googlesource.com/chromium/src.git@lkcr

Patch Set: Rebase onto https://codereview.chromium.org/1504033010 Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef BASE_REFCOUNTED_H_	5 #ifndef BASE_REFCOUNTED_H_

6 #define BASE_REFCOUNTED_H_	6 #define BASE_REFCOUNTED_H_

7	7

8 namespace base {	8 namespace base {

9	9

10 template <typename T>	10 template <typename T>

(...skipping 199 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
210 public SomeOtherInterface,	210 public SomeOtherInterface,

211 public RefcountedType {	211 public RefcountedType {

212 public:	212 public:

213 // DerivedInterface	213 // DerivedInterface

214 void DoFoo() override {}	214 void DoFoo() override {}

215	215

216 // SomeOtherInterface	216 // SomeOtherInterface

217 void DoBar() override {}	217 void DoBar() override {}

218	218

219 protected:	219 protected:

	220 UnsafeInheritanceChain() {}

220 ~UnsafeInheritanceChain() override {}	221 ~UnsafeInheritanceChain() override {}

221 };	222 };

222	223

223 #endif // BASE_REFCOUNTED_H_	224 #endif // BASE_REFCOUNTED_H_

OLD	NEW