Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 1493813002: Disable GL_EXT_texture_rg with GLES 2.0 on Mesa drivers prior version 11.1 (Closed)

Created:
5 years ago by Julien Isorce Samsung
Modified:
5 years ago
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable GL_EXT_texture_rg with GLES 2.0 on Mesa drivers prior version 11.1 Because it wrongly claims supporting GL_EXT_texture_rg. The bug in Mesa has been fixed in 11.1: https://bugs.freedesktop.org/show_bug.cgi?id=93126 Video playback rendering is done differently in Chromium depending if this extension is supported or not. If it uses the extension whereas the driver actually does not support it, this leads to green video frames. BUG=545904 R=bajones@chromium.org, hendrikw@chromium.org, kbr@chromium.org, piman@chromium.org, zmo@chromium.org TEST= --use-gl=egl on Mesa drivers Committed: https://crrev.com/00749f74fa967721a3191baab762c4c7f98e7b77 Cr-Commit-Position: refs/heads/master@{#362986}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -1 line) Patch
M gpu/config/gpu_driver_bug_list_json.cc View 1 2 chunks +22 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Ken Russell (switch to Gerrit)
That's a nice elegant workaround but Mo should review it.
5 years ago (2015-12-02 18:38:03 UTC) #1
Ken Russell (switch to Gerrit)
Also, please update the version number at the top of the file.
5 years ago (2015-12-02 18:38:33 UTC) #2
Zhenyao Mo
LGTM I didn't know mesa has GLES drivers besides GL drivers. https://codereview.chromium.org/1493813002/diff/1/gpu/config/gpu_driver_bug_list_json.cc File gpu/config/gpu_driver_bug_list_json.cc (right): ...
5 years ago (2015-12-02 18:49:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1493813002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1493813002/20001
5 years ago (2015-12-03 14:43:18 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-03 15:54:58 UTC) #7
commit-bot: I haz the power
5 years ago (2015-12-03 15:55:53 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/00749f74fa967721a3191baab762c4c7f98e7b77
Cr-Commit-Position: refs/heads/master@{#362986}

Powered by Google App Engine
This is Rietveld 408576698