Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(802)

Unified Diff: src/mips64/cpu-mips64.cc

Issue 1493793002: MIPS: Fixing CLANG compilation warnings (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/cctest/test-assembler-mips64.cc » ('j') | test/cctest/test-assembler-mips64.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/mips64/cpu-mips64.cc
diff --git a/src/mips64/cpu-mips64.cc b/src/mips64/cpu-mips64.cc
index 6e5910b3ffc5e81b24ac437ac1f48bfee4580b48..ab9cf69620e3ebd315bdb649c9916deeb40d4b5b 100644
--- a/src/mips64/cpu-mips64.cc
+++ b/src/mips64/cpu-mips64.cc
@@ -35,7 +35,7 @@ void CpuFeatures::FlushICache(void* start, size_t size) {
cacheflush(
reinterpret_cast<intptr_t>(start), reinterpret_cast<intptr_t>(end), 0);
#else // ANDROID
- int res;
+ long res; // NOLINT(runtime/int)
balazs.kilvady 2015/12/02 18:49:07 Do we need long at here? syscall returns with int.
ivica.bogosavljevic 2015/12/03 10:36:24 On MIPS64, if we leave int here than we cannot com
// See http://www.linux-mips.org/wiki/Cacheflush_Syscall.
res = syscall(__NR_cacheflush, start, size, ICACHE);
if (res) {
« no previous file with comments | « no previous file | test/cctest/test-assembler-mips64.cc » ('j') | test/cctest/test-assembler-mips64.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698