MIPS: Fixing CLANG compilation warnings

test/cctest/test-assembler-mips64.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 4611 matching lines @@
   __ nop();
 
   CodeDesc desc;
   assm.GetCode(&desc);
   Handle<Code> code = isolate->factory()->NewCode(
       desc, Code::ComputeFlags(Code::STUB), Handle<Code>());
 
   F2 f = FUNCTION_CAST<F2>(code->entry());
 
   uint64_t res = reinterpret_cast<uint64_t>(
-      CALL_GENERATED_CODE(isolate, f, rs_value, rt_value, 0, 0, 0));
+      CALL_GENERATED_CODE(isolate, f, static_cast<int>(rs_value),
+        static_cast<int>(rt_value), 0, 0, 0));

[balazs.kilvady, 2015/12/02 18:49:07]

If F2 function type (with int params) is used above then why we need uint64_t
rs_value, rt_value function args insted of int in run_align(uint64_t rs_value,
uint64_t rt_value, uint8_t bp)? If run_align would get int params then we don't
need reinterpret_cast<>s. Would not that work? Or if 64 bit alignment must be
tested then F4 function type should be used, I guess.

[ivica.bogosavljevic, 2015/12/03 10:36:24]

Acknowledged.

 
   return res;
 }
 
 
 TEST(r6_align) {
   if (kArchVariant == kMips64r6) {
     CcTest::InitializeVM();
 
     struct TestCaseAlign {
@@ skipping 1070 matching lines @@
   __ nop();
 
   CodeDesc desc;
   assm.GetCode(&desc);
   Handle<Code> code = isolate->factory()->NewCode(
       desc, Code::ComputeFlags(Code::STUB), Handle<Code>());
 
   F2 f = FUNCTION_CAST<F2>(code->entry());
 
   uint64_t res = reinterpret_cast<uint64_t>(
-      CALL_GENERATED_CODE(isolate, f, rt_value, 0, 0, 0, 0));
+      CALL_GENERATED_CODE(isolate, f, static_cast<int>(rt_value), 0, 0, 0, 0));
 
   return res;
 }
 
 
 TEST(dsll) {
   CcTest::InitializeVM();
 
   struct TestCaseDsll {
     uint64_t  rt_value;
@@ skipping 94 matching lines @@
       desc, Code::ComputeFlags(Code::STUB), Handle<Code>());
   F2 f = FUNCTION_CAST<F2>(code->entry());
 
   int64_t res = reinterpret_cast<int64_t>(
       CALL_GENERATED_CODE(isolate, f, 42, 42, 0, 0, 0));
   CHECK_EQ(res, 0);
 }
 
 
 #undef __