Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1493773002: Exclude platform_test.cc files when platform does not match (Closed)

Created:
5 years ago by Mark Mentovai
Modified:
5 years ago
Reviewers:
scottmg
CC:
chromium-reviews, noyau (Ping after 24h)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Exclude platform_test.cc files when platform does not match BUG=564631 Committed: https://crrev.com/e96a2edb8efc3bc144917d3c03665161eb68a5c2 Cr-Commit-Position: refs/heads/master@{#362721}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M build/filename_rules.gypi View 2 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Mark Mentovai
I only added _test for platforms where this might come up, not for features that ...
5 years ago (2015-12-02 14:44:48 UTC) #3
scottmg
Huh, I thought "_win" anywhere was enough to exclude it. lgtm
5 years ago (2015-12-02 15:24:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1493773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1493773002/1
5 years ago (2015-12-02 15:26:42 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-02 16:00:24 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-02 16:01:25 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/e96a2edb8efc3bc144917d3c03665161eb68a5c2
Cr-Commit-Position: refs/heads/master@{#362721}

Powered by Google App Engine
This is Rietveld 408576698