Drop [LegacyInterfaceTypeChecking] for the Web Audio API

third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.cpp

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 183 matching lines @@
     if (!isNonNegativeAudioParamTime(time, exceptionState)
         || !isNonNegativeAudioParamTime(timeConstant, exceptionState, "Time constant"))
         return;
 
     insertEvent(ParamEvent::createSetTargetEvent(target, time, timeConstant), exceptionState);
 }
 
 void AudioParamTimeline::setValueCurveAtTime(DOMFloat32Array* curve, double time, double duration, ExceptionState& exceptionState)
 {
     ASSERT(isMainThread());
+    ASSERT(curve);

[Raymond Toy, 2015/12/04 17:30:42]

In a release build, what should we do if curve is null?  This shouldn't happen,
but if it's worth putting in a debug assert we should think about the release
build.

Chris Rogers was fairly careful but silently returning on release builds for bad
situations like this.

[philipj_slow, 2015/12/04 18:31:57]

Would you like me to revert all changes to cpp files, or something else? In all
other cases where bindings guarantees that the input is not null, I've checked
that there are no internal calls and ASSERTed it, to make responsibilities
clear, but I will do whatever you're most comfortable with.

[Raymond Toy, 2015/12/04 21:06:26]

Thanks for the info.  I think this is fine, plus you've added additional tests
for this.

 
     if (!isNonNegativeAudioParamTime(time, exceptionState)
         || !isPositiveAudioParamTime(duration, exceptionState, "Duration"))
         return;
 
     insertEvent(ParamEvent::createSetValueCurveEvent(curve, time, duration), exceptionState);
 }
 
 void AudioParamTimeline::insertEvent(const ParamEvent& event, ExceptionState& exceptionState)
 {
@@ skipping 542 matching lines @@
     // to the end of the values buffer.
     for (; writeIndex < numberOfValues; ++writeIndex)
         values[writeIndex] = value;
 
     return value;
 }
 
 } // namespace blink
 
 #endif // ENABLE(WEB_AUDIO)