LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js - Issue 149373004: [CSS Grid Layout] Implementation of the grid-template shorthand.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js

Issue 149373004: [CSS Grid Layout] Implementation of the grid-template shorthand. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@grid-template-working

Patch Set: Applied suggested changes. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/css-grid-layout/grid-template-shorthand-get-set.html ('K') | « LayoutTests/fast/css-grid-layout/grid-template-shorthand-get-set-expected.txt ('k') | LayoutTests/fast/css-grid-layout/resources/grid-template-shorthand-parsing-utils.js » ('j') | Source/core/css/CSSComputedStyleDeclaration.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js

diff --git a/LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js b/LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js

index c2902202e65613ea25a2f4ffa3a5b91f1b4e6465..7b833b65e2e632aa9efd1f591b4ad4ce6e294a7c 100644

--- a/LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js

+++ b/LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js

@@ -90,6 +90,8 @@ testGridDefinitionsSetBadJSValues("minmax(-1%, 32%)", "minmax(2vw, -6em)");

// Invalid expressions with calc

testGridDefinitionsSetBadJSValues("calc(16px 30px)", "calc(25px + auto)");

testGridDefinitionsSetBadJSValues("minmax(min-content, calc())", "calc(10%(");

+// Forward slash not allowed if not part of a shorthand

+testGridDefinitionsSetBadJSValues("10px /", "15px /");

debug("");

debug("Test setting grid-template-columns and grid-template-rows back to 'none' through JS");