Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(736)

Unified Diff: Source/core/css/parser/BisonCSSParser.h

Issue 149373004: [CSS Grid Layout] Implementation of the grid-template shorthand. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@grid-template-working
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/css/parser/BisonCSSParser.h
diff --git a/Source/core/css/parser/BisonCSSParser.h b/Source/core/css/parser/BisonCSSParser.h
index 62182f8c5bd36f9add796fad7f4350469d1b9700..12eb985fd1447418671c36918ce4b7fb5cdad863 100644
--- a/Source/core/css/parser/BisonCSSParser.h
+++ b/Source/core/css/parser/BisonCSSParser.h
@@ -37,6 +37,7 @@
#include "core/css/MediaQuery.h"
#include "core/css/StylePropertySet.h"
#include "core/css/parser/CSSParserObserver.h"
+#include "core/rendering/style/GridCoordinate.h"
svillar 2014/02/07 12:02:49 I think you don't need this
#include "platform/graphics/Color.h"
#include "wtf/HashSet.h"
#include "wtf/OwnPtr.h"
@@ -165,6 +166,9 @@ public:
PassRefPtr<CSSValue> parseGridPosition();
bool parseIntegerOrStringFromGridPosition(RefPtr<CSSPrimitiveValue>& numericValue, RefPtr<CSSPrimitiveValue>& gridLineName);
bool parseGridItemPositionShorthand(CSSPropertyID, bool important);
+ bool parseGridTemplateShorthand(bool important);
+ bool parseGridTemplateRowsAndAreas(bool important);
+ bool parseGridTemplateAreasRow(NamedGridAreaMap&, const size_t, size_t&);
bool parseGridAreaShorthand(bool important);
bool parseSingleGridAreaLonghand(RefPtr<CSSValue>&);
bool parseGridTrackList(CSSPropertyID, bool important);
@@ -172,7 +176,7 @@ public:
PassRefPtr<CSSValue> parseGridTrackSize(CSSParserValueList& inputList);
PassRefPtr<CSSPrimitiveValue> parseGridBreadth(CSSParserValue*);
PassRefPtr<CSSValue> parseGridTemplateAreas();
- void parseGridLineNames(CSSParserValueList* inputList, CSSValueList&);
+ void parseGridLineNames(CSSParserValueList* inputList, CSSValueList&, bool concat = false);
svillar 2014/02/07 12:02:49 In general I don't like the usage of bools to chan
bool parseClipShape(CSSPropertyID, bool important);

Powered by Google App Engine
This is Rietveld 408576698