Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 1493693003: Revert of [CQ] Update proto format to fix triggered builders. (Closed)

Created:
5 years ago by Michael Achenbach
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [CQ] Update proto format to fix triggered builders. (patchset #1 id:1 of https://codereview.chromium.org/1495443003/ ) Reason for revert: Still not working Original issue's description: > Reland of [CQ] Update proto format to fix triggered builders. (patchset #1 id:1 of https://codereview.chromium.org/1485813004/ ) > > Reason for revert: > Should be fixed after https://codereview.chromium.org/1487413002/ > > Original issue's description: > > Revert of [CQ] Update proto format to fix triggered builders. (patchset #1 id:1 of https://codereview.chromium.org/1486963002/ ) > > > > Reason for revert: > > Maybe causing problems > > > > Original issue's description: > > > [CQ] Update proto format to fix triggered builders. > > > > > > Depends on https://chromereviews.googleplex.com/319777013/ > > > > > > BUG=chromium:561530 > > > LOG=n > > > TBR=sergiyb@chromium.org, tandrii@chromium.org > > > NOTRY=true > > > > > > Committed: https://crrev.com/51d6d619330080a76c5bc7a2ebdafebc6a808aa8 > > > Cr-Commit-Position: refs/heads/master@{#32453} > > > > TBR=sergiyb@chromium.org,tandrii@chromium.org > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=chromium:561530 > > > > Committed: https://crrev.com/79ded5acc9da6a80cbd739c24c6dfa0cf207ae93 > > Cr-Commit-Position: refs/heads/master@{#32464} > > TBR=sergiyb@chromium.org,tandrii@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=chromium:561530 > > Committed: https://crrev.com/3cea13351c1af365013f51c7b67e72eeba79afe6 > Cr-Commit-Position: refs/heads/master@{#32511} TBR=sergiyb@chromium.org,tandrii@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:561530 Committed: https://crrev.com/1125f16088939b9afe3e2d9469b7ec9f2c21d05b Cr-Commit-Position: refs/heads/master@{#32512}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M infra/config/cq.cfg View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Achenbach
Created Revert of [CQ] Update proto format to fix triggered builders.
5 years ago (2015-12-02 13:26:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1493693003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1493693003/1
5 years ago (2015-12-02 13:27:23 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-02 13:27:48 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1125f16088939b9afe3e2d9469b7ec9f2c21d05b Cr-Commit-Position: refs/heads/master@{#32512}
5 years ago (2015-12-02 13:28:12 UTC) #5
Michael Achenbach
5 years ago (2015-12-03 09:16:43 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1494103002/ by machenbach@chromium.org.

The reason for reverting is: Should be fixed after
https://chromereviews.googleplex.com/317197013/,
https://codereview.chromium.org/1487413002/ and
https://codereview.chromium.org/1489293003/ .

Powered by Google App Engine
This is Rietveld 408576698