Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1493673003: Allow null in more 'special' type rules. (Closed)

Created:
5 years ago by sra1
Modified:
5 years ago
Reviewers:
asgerf
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Allow null in more 'special' type rules. We get extra precision from including argument types that produce errors. e.g. {int} + {int,null} --> {int}. Nice improvement on some numerical benchmarks where the result is used as an index where we can now use the builtin indexer. Committed: https://github.com/dart-lang/sdk/commit/9a5640a7d28bcf9a92c0038b3560888fbf51a81b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 6 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
sra1
5 years ago (2015-12-02 21:20:01 UTC) #2
sra1
Committed patchset #1 (id:1) manually as 9a5640a7d28bcf9a92c0038b3560888fbf51a81b (presubmit successful).
5 years ago (2015-12-02 23:43:54 UTC) #4
asgerf
5 years ago (2015-12-03 11:40:02 UTC) #5
Message was sent while issue was closed.
Nice, lgtm, but why only for the right operand?

Could we not get {int,null} + {int,null} -> int?

Powered by Google App Engine
This is Rietveld 408576698