Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 1493673002: Drop [LegacyInterfaceTypeChecking] for HTMLTableElement (Closed)

Created:
5 years ago by philipj_slow
Modified:
5 years ago
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Drop [LegacyInterfaceTypeChecking] for HTMLTableElement Although the behavior when setting caption/tHead/tFoot to null is still not per spec, it's still nice to get the correct exception message when passing some non-null value of the wrong type. BUG=561338 Committed: https://crrev.com/e365c3c580b7d0a92d334be82ca22c6411ab5a1a Cr-Commit-Position: refs/heads/master@{#362700}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -8 lines) Patch
M third_party/WebKit/LayoutTests/fast/dom/HTMLTableElement/exceptions.html View 1 chunk +11 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/HTMLTableElement/exceptions-expected.txt View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/setter-type-enforcement.html View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/setter-type-enforcement-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLTableElement.idl View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1493673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1493673002/1
5 years ago (2015-12-02 10:16:56 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/142774)
5 years ago (2015-12-02 12:12:10 UTC) #4
philipj_slow
PTAL and CQ?
5 years ago (2015-12-02 12:28:48 UTC) #7
jochen (gone - plz use gerrit)
lgtm
5 years ago (2015-12-02 13:10:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1493673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1493673002/1
5 years ago (2015-12-02 13:11:27 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-02 14:16:10 UTC) #12
commit-bot: I haz the power
5 years ago (2015-12-02 14:17:08 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e365c3c580b7d0a92d334be82ca22c6411ab5a1a
Cr-Commit-Position: refs/heads/master@{#362700}

Powered by Google App Engine
This is Rietveld 408576698