Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 149363006: Cleanup ViewManager code (Closed)

Created:
6 years, 10 months ago by Ben Goodger (Google)
Modified:
6 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Cleanup ViewManager code . get rid of most of the separate objects, which were making my head explode. There's now just ViewManagerImpl and ViewImpl. ViewManagerImpl implements NativeViewportClient, LauncherClient, ShellClient, etc. R=sky@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247758

Patch Set 1 #

Patch Set 2 : , #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -94 lines) Patch
mojo/examples/aura_demo/root_window_host_mojo.cc View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/examples/view_manager/view_manager.cc View 2 chunks +56 lines, -93 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Ben Goodger (Google)
Scott, Rietveld is giving me grief unabated. The change to root_window_host_mojo.cc is a one line ...
6 years, 10 months ago (2014-01-29 18:18:54 UTC) #1
sky
LGTM
6 years, 10 months ago (2014-01-29 18:39:08 UTC) #2
Ben Goodger (Google)
6 years, 10 months ago (2014-01-29 22:24:07 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r247758 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698