Source/core/animation/ElementAnimation.cpp - Issue 149363002: Web Animations API: Implement step-middle and steps(x, middle) timing functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/ElementAnimation.cpp

Issue 149363002: Web Animations API: Implement step-middle and steps(x, middle) timing functions. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Remove class in BisonCSSParserTest and change to new license text Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/animations/timing-functions.html ('K') | « Source/core/animation/CompositorAnimationsTest.cpp ('k') | Source/core/animation/ElementAnimationTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/animation/ElementAnimation.cpp

diff --git a/Source/core/animation/ElementAnimation.cpp b/Source/core/animation/ElementAnimation.cpp

index a223fe9a4e0d41f31cf5cb6d7467dd8bbf8adf76..2a28687a7555bab6c08b05cdabd1a910579a8694 100644

--- a/Source/core/animation/ElementAnimation.cpp

+++ b/Source/core/animation/ElementAnimation.cpp

@@ -120,7 +120,7 @@ void ElementAnimation::populateTiming(Timing& timing, Dictionary timingInputDict

String timingFunctionString;

timingInputDictionary.get("easing", timingFunctionString);

- RefPtr<CSSValue> timingFunctionValue = BisonCSSParser::parseAnimationTimingFunctionValue(timingFunctionString);

+ RefPtr<CSSValue> timingFunctionValue = BisonCSSParser::parseAnimationTimingFunctionValue(timingFunctionString, true);

if (timingFunctionValue) {

RefPtr<TimingFunction> timingFunction = CSSToStyleMap::animationTimingFunction(timingFunctionValue.get(), false);

if (timingFunction)