Web Animations API: Implement step-middle and steps(x, middle) timing functions.

Source/core/animation/ElementAnimationTest.cpp

 /*
  * Copyright (c) 2013, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 546 matching lines @@
     timing.timingFunction = defaultTimingFunction;
 
     applyTimingInputString(timing, isolate, "easing", "initial");
     EXPECT_EQ(*defaultTimingFunction.get(), *timing.timingFunction.get());
     timing.timingFunction = defaultTimingFunction;
 
     applyTimingInputString(timing, isolate, "easing", "step-start");
     EXPECT_EQ(*(StepsTimingFunction::preset(StepsTimingFunction::Start)), *timing.timingFunction.get());
     timing.timingFunction = defaultTimingFunction;
 
+    applyTimingInputString(timing, isolate, "easing", "step-middle");
+    EXPECT_EQ(*(StepsTimingFunction::preset(StepsTimingFunction::Middle)), *timing.timingFunction.get());
+    timing.timingFunction = defaultTimingFunction;
+
     applyTimingInputString(timing, isolate, "easing", "step-end");
     EXPECT_EQ(*(StepsTimingFunction::preset(StepsTimingFunction::End)), *timing.timingFunction.get());
     timing.timingFunction = defaultTimingFunction;
 
     applyTimingInputString(timing, isolate, "easing", "cubic-bezier(1, 1, 0.3, 0.3)");
     EXPECT_EQ(*(CubicBezierTimingFunction::create(1, 1, 0.3, 0.3).get()), *timing.timingFunction.get());
     timing.timingFunction = defaultTimingFunction;
 
     applyTimingInputString(timing, isolate, "easing", "steps(3, start)");
-    EXPECT_EQ(*(StepsTimingFunction::create(3, true).get()), *timing.timingFunction.get());
+    EXPECT_EQ(*(StepsTimingFunction::create(3, StepsTimingFunction::StepAtStart).get()), *timing.timingFunction.get());
+    timing.timingFunction = defaultTimingFunction;
+
+    applyTimingInputString(timing, isolate, "easing", "steps(5, middle)");
+    EXPECT_EQ(*(StepsTimingFunction::create(5, StepsTimingFunction::StepAtMiddle).get()), *timing.timingFunction.get());

[eseidel, 2014/02/05 01:41:18]

I'm surprised we have to do this *foo.get() dance every time.  Maybe we should
add a * to this smart ptr type? Maybe it already has one?

[rjwright, 2014/02/17 07:16:53]

Done.

     timing.timingFunction = defaultTimingFunction;
 
     applyTimingInputString(timing, isolate, "easing", "steps(5, end)");
-    EXPECT_EQ(*(StepsTimingFunction::create(5, false).get()), *timing.timingFunction.get());
+    EXPECT_EQ(*(StepsTimingFunction::create(5, StepsTimingFunction::StepAtEnd).get()), *timing.timingFunction.get());
     timing.timingFunction = defaultTimingFunction;
 
     applyTimingInputString(timing, isolate, "easing", "steps(5.6, end)");
     EXPECT_EQ(*defaultTimingFunction.get(), *timing.timingFunction.get());
     timing.timingFunction = defaultTimingFunction;
 
-    // FIXME: Step-middle not yet implemented. Change this test when it is working.
-    applyTimingInputString(timing, isolate, "easing", "steps(5, middle)");
-    EXPECT_EQ(*defaultTimingFunction.get(), *timing.timingFunction.get());
-    timing.timingFunction = defaultTimingFunction;
-
     applyTimingInputString(timing, isolate, "easing", "cubic-bezier(2, 2, 0.3, 0.3)");
     EXPECT_EQ(*defaultTimingFunction.get(), *timing.timingFunction.get());
     timing.timingFunction = defaultTimingFunction;
 
     applyTimingInputString(timing, isolate, "easing", "rubbish");
     EXPECT_EQ(*defaultTimingFunction.get(), *timing.timingFunction.get());
     timing.timingFunction = defaultTimingFunction;
 
     applyTimingInputNumber(timing, isolate, "easing", 2);
     EXPECT_EQ(*defaultTimingFunction.get(), *timing.timingFunction.get());
@@ skipping 19 matching lines @@
     EXPECT_EQ(controlTiming.iterationStart, updatedTiming.iterationStart);
     EXPECT_EQ(controlTiming.iterationCount, updatedTiming.iterationCount);
     EXPECT_EQ(controlTiming.iterationDuration, updatedTiming.iterationDuration);
     EXPECT_EQ(controlTiming.hasIterationDuration, updatedTiming.hasIterationDuration);
     EXPECT_EQ(controlTiming.playbackRate, updatedTiming.playbackRate);
     EXPECT_EQ(controlTiming.direction, updatedTiming.direction);
     EXPECT_EQ(*controlTiming.timingFunction.get(), *updatedTiming.timingFunction.get());
 }
 
 } // namespace WebCore