Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1493533002: Reset top-level class finalization (Closed)

Created:
5 years ago by hausner
Modified:
5 years ago
Reviewers:
zra, regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M runtime/vm/object.h View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/object.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M runtime/vm/parser.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
regis
lgtm https://codereview.chromium.org/1493533002/diff/1/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/1493533002/diff/1/runtime/vm/object.cc#newcode3544 runtime/vm/object.cc:3544: set_state_bits(TypeFinalizedBit::update(false, raw_ptr()->state_bits_)); I wonder about the field offset ...
5 years ago (2015-12-02 00:32:06 UTC) #2
hausner
Thank you. Let's discuss tomorrow in person.
5 years ago (2015-12-02 00:36:19 UTC) #5
hausner
5 years ago (2015-12-02 17:59:43 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
4733386ca8306bd6d17d5613a767e4630a838408 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698