Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Unified Diff: runtime/vm/stub_code_arm.cc

Issue 14935005: Implement a variation of scalar replacement for non-escaping allocations. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: address comments Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/object.cc ('k') | runtime/vm/stub_code_ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/stub_code_arm.cc
diff --git a/runtime/vm/stub_code_arm.cc b/runtime/vm/stub_code_arm.cc
index 39f649785a60c5592c8ee9e7fc9fa3d53f263f82..e520dbfc7e4a6ddb6a7b89c3f45cee38c335df8c 100644
--- a/runtime/vm/stub_code_arm.cc
+++ b/runtime/vm/stub_code_arm.cc
@@ -394,11 +394,17 @@ static void GenerateDeoptimizationSequence(Assembler* assembler,
if (preserve_result) {
__ Push(R1); // Preserve result, it will be GC-d here.
}
- __ CallRuntime(kDeoptimizeMaterializeDoublesRuntimeEntry);
+ __ PushObject(Smi::ZoneHandle()); // Space for the result.
+ __ CallRuntime(kDeoptimizeMaterializeRuntimeEntry);
+ // Result tells stub how many bytes to remove from the expression stack
+ // of the bottom-most frame. They were used as materialization arguments.
+ __ Pop(R1);
if (preserve_result) {
__ Pop(R0); // Restore result.
}
__ LeaveStubFrame();
+ // Remove materialization arguments.
+ __ add(SP, SP, ShifterOperand(R1, ASR, kSmiTagSize));
__ Ret();
}
« no previous file with comments | « runtime/vm/object.cc ('k') | runtime/vm/stub_code_ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698