Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 1493433002: Precompilation: (Closed)

Created:
5 years ago by rmacnak
Modified:
5 years ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Precompilation: - Weaken check in Dart_New: it is okay to invoke a factory constructor or redirecting constructor of a class that was removed. We only need the class of a generative constructor to have been retained. - Fix crash sending two-byte symbols in isolate messages. Only occurs in precompilation because there are no two-byte string literals in the core libraries, and so no type-byte entries in the VM isolate's symbol table. - Fix crash getting expression snippet for assertion failures. R=srdjan@google.com Committed: https://github.com/dart-lang/sdk/commit/414dd5d7788f6f579a02f96a9de83d720c149630

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M runtime/vm/dart_api_impl.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M runtime/vm/object.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/vm/snapshot.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
5 years ago (2015-12-01 19:20:39 UTC) #2
srdjan
lgtm
5 years ago (2015-12-01 19:39:51 UTC) #3
rmacnak
5 years ago (2015-12-01 20:44:37 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
414dd5d7788f6f579a02f96a9de83d720c149630 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698