Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1550)

Issue 1493413004: ipc: Allow attachment brokering for shared memory handles. (Closed)

Created:
5 years ago by erikchen
Modified:
4 years, 11 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, gavinp+memory_chromium.org, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@temp1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ipc: Implement attachment brokering for SharedMemoryHandle on Windows. Each SharedMemoryHandle is backed by a HANDLE, and that HANDLE is associated with a specific process. If a SharedMemoryHandle passed to IPC is associated with the current process, the IPC stack will automatically broker the handle to the destination process. This functionality has been implemented and tested, but is not yet turned on, because there are a couple of Windows-specific Chrome IPC messages that intentionally pass a HANDLE associated with another process. I will write a follow-up CL that turns on this functionality, and removes those IPC messages. BUG=493414 Committed: https://crrev.com/3d87ecf7392672dbd0aaabc042caf29cf63631cf Cr-Commit-Position: refs/heads/master@{#368244}

Patch Set 1 #

Patch Set 2 : gyp fix #

Patch Set 3 : Fix a double release bug. #

Patch Set 4 : Fix ownership problem in receiving process for tests. #

Patch Set 5 : Disable functionality and test. #

Patch Set 6 : Fix some comments. #

Patch Set 7 : Fix another test. #

Patch Set 8 : Fix more tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -115 lines) Patch
M ipc/BUILD.gn View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M ipc/attachment_broker_privileged_win.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ipc/attachment_broker_privileged_win.cc View 1 2 2 chunks +7 lines, -2 lines 0 comments Download
M ipc/attachment_broker_privileged_win_unittest.cc View 1 2 3 4 5 6 7 8 chunks +102 lines, -32 lines 0 comments Download
D ipc/attachment_broker_unprivileged_win_unittest.cc View 1 chunk +0 lines, -51 lines 0 comments Download
M ipc/handle_attachment_win.h View 1 2 3 4 5 3 chunks +8 lines, -7 lines 0 comments Download
M ipc/handle_attachment_win.cc View 1 2 3 1 chunk +14 lines, -8 lines 0 comments Download
M ipc/handle_win.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M ipc/ipc.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M ipc/ipc_message_utils.cc View 1 2 4 chunks +3 lines, -12 lines 0 comments Download
M ipc/ipc_test_messages.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 44 (22 generated)
erikchen
tsepez: Please review.
5 years ago (2015-12-04 02:00:48 UTC) #3
Tom Sepez
lgtm
5 years ago (2015-12-04 17:34:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1493413004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1493413004/1
5 years ago (2015-12-04 21:36:39 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/75745)
5 years ago (2015-12-04 21:48:34 UTC) #8
erikchen
mark: Please review base/
5 years ago (2015-12-05 00:03:25 UTC) #10
Mark Mentovai
LGTM
5 years ago (2015-12-05 00:14:15 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1493413004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1493413004/20001
5 years ago (2015-12-08 01:19:50 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/77124)
5 years ago (2015-12-08 04:04:54 UTC) #16
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1493413004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1493413004/20001
4 years, 11 months ago (2015-12-31 01:39:12 UTC) #18
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/132068)
4 years, 11 months ago (2015-12-31 01:46:52 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1493413004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1493413004/40001
4 years, 11 months ago (2016-01-04 21:10:40 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/149653)
4 years, 11 months ago (2016-01-04 22:20:48 UTC) #25
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1493413004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1493413004/80001
4 years, 11 months ago (2016-01-06 01:09:23 UTC) #28
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1493413004/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1493413004/120001
4 years, 11 months ago (2016-01-06 02:14:21 UTC) #30
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/150482)
4 years, 11 months ago (2016-01-06 03:37:39 UTC) #32
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1493413004/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1493413004/140001
4 years, 11 months ago (2016-01-06 22:18:17 UTC) #34
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-06 23:29:27 UTC) #36
erikchen
tsepez: Please review again, as it's been a month and I've made some changes.
4 years, 11 months ago (2016-01-07 00:29:36 UTC) #37
Tom Sepez
lgtm
4 years, 11 months ago (2016-01-07 23:02:41 UTC) #38
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1493413004/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1493413004/140001
4 years, 11 months ago (2016-01-08 00:53:20 UTC) #41
commit-bot: I haz the power
Committed patchset #8 (id:140001)
4 years, 11 months ago (2016-01-08 02:17:12 UTC) #42
commit-bot: I haz the power
4 years, 11 months ago (2016-01-08 02:18:43 UTC) #44
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/3d87ecf7392672dbd0aaabc042caf29cf63631cf
Cr-Commit-Position: refs/heads/master@{#368244}

Powered by Google App Engine
This is Rietveld 408576698